From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Babu Moger <babu.moger@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Dan Williams <dan.j.williams@intel.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Tejun Heo <tj@kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] Ajust lockdep static allocations for sparc
Date: Tue, 29 Nov 2016 12:14:48 +0100 [thread overview]
Message-ID: <CAMuHMdU13YdzoM4zTaiUvhzbgSVGeJgn6k7nyo2RayURiezK2w@mail.gmail.com> (raw)
In-Reply-To: <1475004808-91920-1-git-send-email-babu.moger@oracle.com>
CC linux-renesas-soc
On Tue, Sep 27, 2016 at 9:33 PM, Babu Moger <babu.moger@oracle.com> wrote:
> These patches limit the static allocations for lockdep data structures
> used for debugging locking correctness. For sparc, all the kernel's code,
> data, and bss, must have locked translations in the TLB so that we don't
> get TLB misses on kernel code and data. Current sparc chips have 8 TLB
> entries available that may be locked down, and with a 4mb page size,
> this gives a maximum of 32MB. With PROVE_LOCKING we could go over this
> limit and cause system boot-up problems. These patches limit the static
> allocations so that everything fits in current required size limit.
>
> patch 1 : Adds new config parameter CONFIG_PROVE_LOCKING_SMALL
> Patch 2 : Adjusts the sizes based on the new config parameter
Cool, this is also useful on other platforms!
E.g. on r8a7791/koelsch, I cannot boot an shmobile_defconfig plus
CONFIG_PROVE_LOCKING kernel.
Forcing CONFIG_PROVE_LOCKING_SMALL=y in Kconfig fixes that.
Should it become a user-selectable symbol?
> v2-> v3:
> Some more comments from Sam Ravnborg and Peter Zijlstra.
> Defined PROVE_LOCKING_SMALL as invisible and moved the selection to
> arch/sparc/Kconfig.
>
> v1-> v2:
> As suggested by Peter Zijlstra, keeping the default as is.
> Introduced new config variable CONFIG_PROVE_LOCKING_SMALL
> to handle sparc specific case.
>
> v0:
> Initial revision.
>
> Babu Moger (2):
> config: Adding the new config parameter CONFIG_PROVE_LOCKING_SMALL
> for sparc
> lockdep: Limit static allocations if PROVE_LOCKING_SMALL is defined
>
> arch/sparc/Kconfig | 1 +
> kernel/locking/lockdep_internals.h | 20 +++++++++++++++++---
> lib/Kconfig.debug | 3 +++
> 3 files changed, 21 insertions(+), 3 deletions(-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2016-11-29 11:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 19:33 [PATCH v3 0/2] Ajust lockdep static allocations for sparc Babu Moger
2016-09-27 19:33 ` [PATCH v3 1/2] config: Adding the new config parameter CONFIG_PROVE_LOCKING_SMALL " Babu Moger
2016-09-28 8:39 ` Peter Zijlstra
2016-09-29 13:53 ` Babu Moger
2016-09-30 5:19 ` David Miller
2016-10-05 22:56 ` Babu Moger
2016-10-06 4:27 ` Sam Ravnborg
2016-09-28 20:51 ` Sam Ravnborg
2016-09-27 19:33 ` [PATCH v3 2/2] lockdep: Limit static allocations if PROVE_LOCKING_SMALL is defined Babu Moger
2016-09-28 20:51 ` Sam Ravnborg
2016-09-29 13:55 ` Babu Moger
2016-11-18 19:34 ` [PATCH v3 0/2] Ajust lockdep static allocations for sparc David Miller
2016-11-19 11:53 ` Peter Zijlstra
2016-11-21 7:17 ` Ingo Molnar
2016-11-29 11:14 ` Geert Uytterhoeven [this message]
2016-11-29 11:41 ` Peter Zijlstra
2016-11-29 11:52 ` Geert Uytterhoeven
2016-11-29 12:29 ` Peter Zijlstra
2016-11-29 12:35 ` Peter Zijlstra
2016-11-29 13:26 ` Geert Uytterhoeven
2016-11-29 13:31 ` Peter Zijlstra
2016-11-29 13:39 ` Geert Uytterhoeven
2016-11-29 13:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU13YdzoM4zTaiUvhzbgSVGeJgn6k7nyo2RayURiezK2w@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=babu.moger@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).