* [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
@ 2016-09-28 15:28 shyam saini
2016-10-02 14:58 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: shyam saini @ 2016-09-28 15:28 UTC (permalink / raw)
To: labbott; +Cc: sumit.semwal, gregkh, linux-kernel, devel, arve, shyam saini
Remove the explicit NULL comparison and rewrite in a compact form.
Signed-off-by: shyam saini <mayhs11saini@gmail.com>
---
drivers/staging/android/ion/ion_of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index 01f3067..485fb0f 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -36,7 +36,7 @@ int ion_parse_dt_heap_common(struct device_node *heap_node,
break;
}
- if (compatible[i].name == NULL)
+ if (!compatible[i].name)
return -ENODEV;
heap->id = compatible[i].heap_id;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
2016-09-28 15:28 [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle shyam saini
@ 2016-10-02 14:58 ` Greg KH
2016-10-02 15:21 ` Shyam Saini
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-10-02 14:58 UTC (permalink / raw)
To: shyam saini; +Cc: labbott, sumit.semwal, linux-kernel, devel, arve
On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form.
>
> Signed-off-by: shyam saini <mayhs11saini@gmail.com>
> ---
> drivers/staging/android/ion/ion_of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
2016-10-02 14:58 ` Greg KH
@ 2016-10-02 15:21 ` Shyam Saini
2016-10-02 15:37 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Shyam Saini @ 2016-10-02 15:21 UTC (permalink / raw)
To: Greg KH; +Cc: labbott, sumit.semwal, linux-kernel, devel, arve
On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> >
> > Remove the explicit NULL comparison and rewrite in a compact form.
> >
> > Signed-off-by: shyam saini <mayhs11saini@gmail.com>
> > ---
> > drivers/staging/android/ion/ion_of.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Does not apply to my tree :(
Do I need to rebase it? Because I have already included all the
maintainers in the patch which I got from scripts/get_maintainer.pl.
Thanks,
Shyam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
2016-10-02 15:21 ` Shyam Saini
@ 2016-10-02 15:37 ` Greg KH
2016-10-02 16:07 ` Shyam Saini
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-10-02 15:37 UTC (permalink / raw)
To: Shyam Saini; +Cc: labbott, sumit.semwal, linux-kernel, devel, arve
On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote:
> On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > >
> > > Remove the explicit NULL comparison and rewrite in a compact form.
> > >
> > > Signed-off-by: shyam saini <mayhs11saini@gmail.com>
> > > ---
> > > drivers/staging/android/ion/ion_of.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Does not apply to my tree :(
>
>
> Do I need to rebase it? Because I have already included all the
> maintainers in the patch which I got from scripts/get_maintainer.pl.
If you want it applied, yes, you need to rebase it. Listing the
maintainers doesn't help the patch to somehow magically be able to be
applied to the tree :)
Please work against my staging-testing branch of the staging.git tree,
as it has a lot of patches I just accepted in it that are not yet in
linux-next.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
2016-10-02 15:37 ` Greg KH
@ 2016-10-02 16:07 ` Shyam Saini
2016-10-02 16:16 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Shyam Saini @ 2016-10-02 16:07 UTC (permalink / raw)
To: Greg KH; +Cc: labbott, sumit.semwal, linux-kernel, devel, arve
On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote:
> On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote:
> >
> > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> > >
> > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > > >
> > > >
> > > > Remove the explicit NULL comparison and rewrite in a compact
> > > > form.
> > > >
> > > > Signed-off-by: shyam saini <mayhs11saini@gmail.com>
> > > > ---
> > > > drivers/staging/android/ion/ion_of.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > Does not apply to my tree :(
> >
> > Do I need to rebase it? Because I have already included all the
> > maintainers in the patch which I got from
> > scripts/get_maintainer.pl.
> If you want it applied, yes, you need to rebase it. Listing the
> maintainers doesn't help the patch to somehow magically be able to be
> applied to the tree :)
>
> Please work against my staging-testing branch of the staging.git
> tree,
> as it has a lot of patches I just accepted in it that are not yet in
> linux-next.
>
> thanks,
>
> greg k-h
>From now onward I will be working on your staging-testing tree.
But then why some of my patches which were based on linux-next were
accepted?
for example today You've accepted
my patch "Staging: vt6655: Remove explicit NULL comparison using
Coccinelle"
with commit id 4d932504b534584e116b400dd6e7b8ce7deb455c,
which you can check on
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
This patch was based on linux-next tree.
Please clear my confusion.
Thanks,
Shyam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle
2016-10-02 16:07 ` Shyam Saini
@ 2016-10-02 16:16 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2016-10-02 16:16 UTC (permalink / raw)
To: Shyam Saini; +Cc: labbott, sumit.semwal, linux-kernel, devel, arve
On Sun, Oct 02, 2016 at 09:37:17PM +0530, Shyam Saini wrote:
> On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote:
> > On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote:
> > >
> > > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote:
> > > >
> > > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote:
> > > > >
> > > > >
> > > > > Remove the explicit NULL comparison and rewrite in a compact
> > > > > form.
> > > > >
> > > > > Signed-off-by: shyam saini <mayhs11saini@gmail.com>
> > > > > ---
> > > > > drivers/staging/android/ion/ion_of.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > Does not apply to my tree :(
> > >
> > > Do I need to rebase it? Because I have already included all the
> > > maintainers in the patch which I got from
> > > scripts/get_maintainer.pl.
> > If you want it applied, yes, you need to rebase it. Listing the
> > maintainers doesn't help the patch to somehow magically be able to be
> > applied to the tree :)
> >
> > Please work against my staging-testing branch of the staging.git
> > tree,
> > as it has a lot of patches I just accepted in it that are not yet in
> > linux-next.
> >
> > thanks,
> >
> > greg k-h
>
>
> >From now onward I will be working on your staging-testing tree.
>
> But then why some of my patches which were based on linux-next were
> accepted?
>
> for example today You've accepted
> my patch "Staging: vt6655: Remove explicit NULL comparison using
> Coccinelle"
>
> with commit id 4d932504b534584e116b400dd6e7b8ce7deb455c,
>
> which you can check on
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> This patch was based on linux-next tree.
Because maybe others have sent patches in for this specific area of the
kernel, or there are changes made by other developer's trees (like the
iio maintainer) for this driver. linux-next merges all of our trees
together, and usually is the correct thing to use. But sometimes it
doesn't work out due to the large number of patches I get for the
staging tree (about 20-50 a day, sometimes more.)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-02 16:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-28 15:28 [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle shyam saini
2016-10-02 14:58 ` Greg KH
2016-10-02 15:21 ` Shyam Saini
2016-10-02 15:37 ` Greg KH
2016-10-02 16:07 ` Shyam Saini
2016-10-02 16:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).