* [PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock
@ 2016-09-30 21:56 Alexey Khoroshilov
2016-10-03 6:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2016-09-30 21:56 UTC (permalink / raw)
To: Florian Fainelli, Andrew Lunn
Cc: Alexey Khoroshilov, David S. Miller, netdev, linux-kernel, ldv-project
There is no need to clk_disable_unprepare(dev->clk)
before it was initialized.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/net/ethernet/marvell/mvmdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
index 8982c882af1b..a0d1b084ecec 100644
--- a/drivers/net/ethernet/marvell/mvmdio.c
+++ b/drivers/net/ethernet/marvell/mvmdio.c
@@ -211,8 +211,7 @@ static int orion_mdio_probe(struct platform_device *pdev)
dev->regs = devm_ioremap(&pdev->dev, r->start, resource_size(r));
if (!dev->regs) {
dev_err(&pdev->dev, "Unable to remap SMI register\n");
- ret = -ENODEV;
- goto out_mdio;
+ return -ENODEV;
}
init_waitqueue_head(&dev->smi_busy_wait);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock
2016-09-30 21:56 [PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock Alexey Khoroshilov
@ 2016-10-03 6:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-10-03 6:03 UTC (permalink / raw)
To: khoroshilov; +Cc: f.fainelli, andrew, netdev, linux-kernel, ldv-project
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 1 Oct 2016 00:56:37 +0300
> There is no need to clk_disable_unprepare(dev->clk)
> before it was initialized.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-03 6:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-30 21:56 [PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock Alexey Khoroshilov
2016-10-03 6:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).