* [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure
@ 2016-08-28 20:26 Julia Lawall
2016-09-09 4:27 ` Guenter Roeck
2016-10-08 14:01 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2016-08-28 20:26 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: kernel-janitors, Guenter Roeck, linux-watchdog, linux-kernel
iTCO_wdt_pm, of type struct dev_pm_ops, is never modified, so declare it as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/watchdog/iTCO_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
index 54cab18..06fcb6c 100644
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@ -629,7 +629,7 @@ static int iTCO_wdt_resume_noirq(struct device *dev)
return 0;
}
-static struct dev_pm_ops iTCO_wdt_pm = {
+static const struct dev_pm_ops iTCO_wdt_pm = {
.suspend_noirq = iTCO_wdt_suspend_noirq,
.resume_noirq = iTCO_wdt_resume_noirq,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure
2016-08-28 20:26 [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure Julia Lawall
@ 2016-09-09 4:27 ` Guenter Roeck
2016-10-08 14:01 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2016-09-09 4:27 UTC (permalink / raw)
To: Julia Lawall, Wim Van Sebroeck
Cc: kernel-janitors, linux-watchdog, linux-kernel
On 08/28/2016 01:26 PM, Julia Lawall wrote:
> iTCO_wdt_pm, of type struct dev_pm_ops, is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure
2016-08-28 20:26 [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure Julia Lawall
2016-09-09 4:27 ` Guenter Roeck
@ 2016-10-08 14:01 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2016-10-08 14:01 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, Guenter Roeck, linux-watchdog, linux-kernel
Hi Julia,
> iTCO_wdt_pm, of type struct dev_pm_ops, is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
This patch and your constify watchdog_ops structures were added to linux-watchdog-next almost 2 weeks ago.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-08 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-28 20:26 [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure Julia Lawall
2016-09-09 4:27 ` Guenter Roeck
2016-10-08 14:01 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).