From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state
Date: Sat, 8 Oct 2016 10:42:03 -0600 [thread overview]
Message-ID: <20161008164203.GB29734@obsidianresearch.com> (raw)
In-Reply-To: <20161008160006.GA25893@intel.com>
On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote:
> Rather you it would be better not to use cmdReady/goIdle at all if
> kernel is not compiled with CONFIG_PM.
It would be best practice to ensure the tpm is powered up no matter
how the kernel is compiled.. The firmware may have left it in idle or
something
FWIW, I broadly agree there is no need to put the device into idle on
the error paths. It probably wasn't idle when the driver attached to
it.
Jason
next prev parent reply other threads:[~2016-10-08 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 11:59 [PATCH v4 0/4] tpm/tpm_crb: implement power management Tomas Winkler
2016-10-08 11:59 ` [PATCH v4 1/4] tpm/tpm_crb: implement tpm crb idle state Tomas Winkler
2016-10-08 16:30 ` Jarkko Sakkinen
2016-10-08 11:59 ` [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during " Tomas Winkler
2016-10-08 12:50 ` Jarkko Sakkinen
2016-10-08 14:27 ` Winkler, Tomas
2016-10-08 16:00 ` Jarkko Sakkinen
2016-10-08 16:42 ` Jason Gunthorpe [this message]
2016-10-08 16:58 ` Winkler, Tomas
2016-10-08 17:08 ` Jarkko Sakkinen
2016-10-08 16:56 ` Winkler, Tomas
2016-10-08 17:06 ` Jarkko Sakkinen
2016-10-08 17:27 ` Winkler, Tomas
2016-10-08 18:53 ` [tpmdd-devel] " Winkler, Tomas
2016-10-08 11:59 ` [PATCH 3/4] tpm/tpm_crb: open code the crb_init into acpi_add Tomas Winkler
2016-10-08 11:59 ` [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Tomas Winkler
2016-10-08 12:47 ` Jarkko Sakkinen
2016-10-08 13:37 ` Winkler, Tomas
2016-10-08 16:01 ` Jarkko Sakkinen
2016-10-08 18:18 ` Winkler, Tomas
2016-10-08 18:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161008164203.GB29734@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).