* [PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE
@ 2016-10-03 16:07 Sergio Paracuellos
2016-10-09 14:31 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Sergio Paracuellos @ 2016-10-03 16:07 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef CTLX_STATE
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 3 +--
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 43c299c..ab6d37c 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1169,7 +1169,6 @@ enum ctlx_state {
CTLX_REQ_COMPLETE, /* OUT URB complete */
CTLX_RESP_COMPLETE /* IN URB received */
};
-typedef enum ctlx_state CTLX_STATE;
struct hfa384x_usbctlx;
struct hfa384x;
@@ -1186,7 +1185,7 @@ struct hfa384x_usbctlx {
union hfa384x_usbout outbuf; /* pkt buf for OUT */
union hfa384x_usbin inbuf; /* pkt buf for IN(a copy) */
- CTLX_STATE state; /* Tracks running state */
+ enum ctlx_state state; /* Tracks running state */
struct completion done;
volatile int reapable; /* Food for the reaper task */
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6a107f8..1a8d3ac 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -263,7 +263,7 @@ struct usbctlx_completor {
static int hfa384x_isgood_pdrcode(u16 pdrcode);
-static inline const char *ctlxstr(CTLX_STATE s)
+static inline const char *ctlxstr(enum ctlx_state s)
{
static const char * const ctlx_str[] = {
"Initial state",
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE
2016-10-03 16:07 [PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE Sergio Paracuellos
@ 2016-10-09 14:31 ` Greg KH
2016-10-09 15:13 ` [PATCH] staging: wlan-ng: " Sergio Paracuellos
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-10-09 14:31 UTC (permalink / raw)
To: Sergio Paracuellos; +Cc: devel, linux-kernel
On Mon, Oct 03, 2016 at 06:07:03PM +0200, Sergio Paracuellos wrote:
> This patch fixes the following checkpatch.pl warning in hfa384x.h:
> WARNING: do not add new typedefs
>
> It applies for typedef CTLX_STATE
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x.h | 3 +--
> drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
Subject also wrong :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: wlan-ng: avoid new typedef CTLX_STATE
2016-10-09 14:31 ` Greg KH
@ 2016-10-09 15:13 ` Sergio Paracuellos
0 siblings, 0 replies; 3+ messages in thread
From: Sergio Paracuellos @ 2016-10-09 15:13 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef CTLX_STATE
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/hfa384x.h | 3 +--
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 43c299c..ab6d37c 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1169,7 +1169,6 @@ enum ctlx_state {
CTLX_REQ_COMPLETE, /* OUT URB complete */
CTLX_RESP_COMPLETE /* IN URB received */
};
-typedef enum ctlx_state CTLX_STATE;
struct hfa384x_usbctlx;
struct hfa384x;
@@ -1186,7 +1185,7 @@ struct hfa384x_usbctlx {
union hfa384x_usbout outbuf; /* pkt buf for OUT */
union hfa384x_usbin inbuf; /* pkt buf for IN(a copy) */
- CTLX_STATE state; /* Tracks running state */
+ enum ctlx_state state; /* Tracks running state */
struct completion done;
volatile int reapable; /* Food for the reaper task */
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6a107f8..1a8d3ac 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -263,7 +263,7 @@ struct usbctlx_completor {
static int hfa384x_isgood_pdrcode(u16 pdrcode);
-static inline const char *ctlxstr(CTLX_STATE s)
+static inline const char *ctlxstr(enum ctlx_state s)
{
static const char * const ctlx_str[] = {
"Initial state",
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-09 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-03 16:07 [PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE Sergio Paracuellos
2016-10-09 14:31 ` Greg KH
2016-10-09 15:13 ` [PATCH] staging: wlan-ng: " Sergio Paracuellos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).