From: Michal Hocko <mhocko@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: linux.git: printk() problem
Date: Thu, 13 Oct 2016 08:26:00 +0200 [thread overview]
Message-ID: <20161013062600.GB21678@dhcp22.suse.cz> (raw)
In-Reply-To: <1476288538.16823.9.camel@perches.com>
On Wed 12-10-16 09:08:58, Joe Perches wrote:
> On Wed, 2016-10-12 at 16:35 +0200, Michal Hocko wrote:
> > On Wed 12-10-16 22:30:03, Tetsuo Handa wrote:
> > > Hello.
> > >
> > > I noticed that current linux.git generates hardly readable console output
> > > due to KERN_CONT changes. Are you suggesting developers that output like
> > > this be fixed?
> >
> >
> > Joe has already posted a patch
> > http://lkml.kernel.org/r/c7df37c8665134654a17aaeb8b9f6ace1d6db58b.1476239034.git.joe@perches.com
> >
> > And in general I think that adding those KERN_CONT is a good thing to
> > do.
>
> As do I, but there are about a quarter _million_ uses of
> printk/logging messages in the kernel tree with newlines.
>
> Maybe 100 or so of the existing messages lack terminating
> newlines.
I think they are not critical and can be fix once somebody notices.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-10-13 6:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:30 linux.git: printk() problem Tetsuo Handa
2016-10-12 14:35 ` Michal Hocko
2016-10-12 16:08 ` Joe Perches
2016-10-13 6:26 ` Michal Hocko [this message]
2016-10-13 9:29 ` Joe Perches
2016-10-13 10:04 ` Michal Hocko
2016-10-13 10:20 ` Joe Perches
2016-10-13 11:06 ` Michal Hocko
2016-10-12 15:47 ` Linus Torvalds
2016-10-12 16:16 ` Joe Perches
2016-10-12 16:54 ` Linus Torvalds
2016-10-12 18:50 ` [PATCH] acpi_os_vprintf: Use printk_get_level() to avoid unnecessary KERN_CONT Joe Perches
2016-10-13 21:59 ` Rafael J. Wysocki
2016-10-23 9:22 ` linux.git: printk() problem Geert Uytterhoeven
2016-10-23 18:11 ` Linus Torvalds
2016-10-23 19:06 ` Joe Perches
2016-10-23 19:32 ` Linus Torvalds
2016-10-23 19:46 ` Linus Torvalds
2016-10-24 11:15 ` Geert Uytterhoeven
2016-10-24 14:08 ` Sergey Senozhatsky
2016-10-24 14:23 ` Sergey Senozhatsky
2016-10-24 17:54 ` Linus Torvalds
2016-10-24 17:55 ` Linus Torvalds
2016-10-25 1:55 ` Sergey Senozhatsky
2016-10-25 2:06 ` Linus Torvalds
2016-10-25 2:22 ` Linus Torvalds
2016-10-25 4:06 ` Sergey Senozhatsky
2016-10-25 4:13 ` Joe Perches
2016-10-25 4:15 ` Linus Torvalds
2016-10-25 4:44 ` Sergey Senozhatsky
2016-10-25 14:44 ` Petr Mladek
2016-11-09 15:47 ` Petr Mladek
2016-10-25 2:24 ` Sergey Senozhatsky
2016-10-23 20:33 ` Joe Perches
2016-10-23 21:13 ` Linus Torvalds
2016-10-25 14:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013062600.GB21678@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).