From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.cz>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: linux.git: printk() problem
Date: Mon, 24 Oct 2016 23:08:45 +0900 [thread overview]
Message-ID: <20161024140845.GA626@swordfish> (raw)
In-Reply-To: <CA+55aFzm6RpkaiDzS_q3J=4_hykCCgAZLjEf5nffgSZjUpQ17A@mail.gmail.com>
Hello,
thanks for Cc-ing.
On (10/23/16 12:46), Linus Torvalds wrote:
> +static void deferred_cont_flush(void)
> +{
> + static DEFINE_TIMER(timer, flush_timer, 0, 0);
> +
> + if (!cont.len)
> return;
> + mod_timer(&timer, jiffies + HZ/10);
> }
[..]
> @@ -2360,6 +2285,8 @@ void console_unlock(void)
> return;
> }
>
> + deferred_cont_flush();
> +
is mod_timer() safe enough to rely on/call from
panic()->console_flush_on_panic()->console_unlock() ?
shouldn't deferred_cont_flush() be called every time we jump
to `again' label in console_unlock()?
timer has debug object support, which probably can printk(), but
that shouldn't cause any troubles, I suppose.
-ss
next prev parent reply other threads:[~2016-10-24 14:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:30 linux.git: printk() problem Tetsuo Handa
2016-10-12 14:35 ` Michal Hocko
2016-10-12 16:08 ` Joe Perches
2016-10-13 6:26 ` Michal Hocko
2016-10-13 9:29 ` Joe Perches
2016-10-13 10:04 ` Michal Hocko
2016-10-13 10:20 ` Joe Perches
2016-10-13 11:06 ` Michal Hocko
2016-10-12 15:47 ` Linus Torvalds
2016-10-12 16:16 ` Joe Perches
2016-10-12 16:54 ` Linus Torvalds
2016-10-12 18:50 ` [PATCH] acpi_os_vprintf: Use printk_get_level() to avoid unnecessary KERN_CONT Joe Perches
2016-10-13 21:59 ` Rafael J. Wysocki
2016-10-23 9:22 ` linux.git: printk() problem Geert Uytterhoeven
2016-10-23 18:11 ` Linus Torvalds
2016-10-23 19:06 ` Joe Perches
2016-10-23 19:32 ` Linus Torvalds
2016-10-23 19:46 ` Linus Torvalds
2016-10-24 11:15 ` Geert Uytterhoeven
2016-10-24 14:08 ` Sergey Senozhatsky [this message]
2016-10-24 14:23 ` Sergey Senozhatsky
2016-10-24 17:54 ` Linus Torvalds
2016-10-24 17:55 ` Linus Torvalds
2016-10-25 1:55 ` Sergey Senozhatsky
2016-10-25 2:06 ` Linus Torvalds
2016-10-25 2:22 ` Linus Torvalds
2016-10-25 4:06 ` Sergey Senozhatsky
2016-10-25 4:13 ` Joe Perches
2016-10-25 4:15 ` Linus Torvalds
2016-10-25 4:44 ` Sergey Senozhatsky
2016-10-25 14:44 ` Petr Mladek
2016-11-09 15:47 ` Petr Mladek
2016-10-25 2:24 ` Sergey Senozhatsky
2016-10-23 20:33 ` Joe Perches
2016-10-23 21:13 ` Linus Torvalds
2016-10-25 14:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024140845.GA626@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.cz \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).