* [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr
@ 2016-10-13 2:34 Longpeng(Mike)
2016-10-13 12:36 ` Radim Krčmář
0 siblings, 1 reply; 2+ messages in thread
From: Longpeng(Mike) @ 2016-10-13 2:34 UTC (permalink / raw)
To: rkrcmar, pbonzini, tglx, mingo, hpa, x86
Cc: kvm, linux-kernel, wu.wubin, zhaoshenglong, longpeng2
Since Paolo has removed irq-enable-operation in vmx_handle_external_intr
(KVM: x86: use guest_exit_irqoff), the original comment about the IF bit
in rflags is incorrect and stale now, so remove it.
Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
---
Hi Radim,
Changes since v1:
- remove this stale comment instead.
---
arch/x86/kvm/vmx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index cf1b16d..e06c8b1 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -8646,11 +8646,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu)
u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
register void *__sp asm(_ASM_SP);
- /*
- * If external interrupt exists, IF bit is set in rflags/eflags on the
- * interrupt stack frame, and interrupt will be enabled on a return
- * from interrupt handler.
- */
if ((exit_intr_info & (INTR_INFO_VALID_MASK | INTR_INFO_INTR_TYPE_MASK))
== (INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR)) {
unsigned int vector;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr
2016-10-13 2:34 [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr Longpeng(Mike)
@ 2016-10-13 12:36 ` Radim Krčmář
0 siblings, 0 replies; 2+ messages in thread
From: Radim Krčmář @ 2016-10-13 12:36 UTC (permalink / raw)
To: Longpeng(Mike)
Cc: pbonzini, tglx, mingo, hpa, x86, kvm, linux-kernel, wu.wubin,
zhaoshenglong
2016-10-13 10:34+0800, Longpeng(Mike):
> Since Paolo has removed irq-enable-operation in vmx_handle_external_intr
> (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit
> in rflags is incorrect and stale now, so remove it.
>
> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
> ---
> Hi Radim,
>
> Changes since v1:
> - remove this stale comment instead.
> ---
Applied to kvm/queue, thanks.
> arch/x86/kvm/vmx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index cf1b16d..e06c8b1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -8646,11 +8646,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu)
> u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
> register void *__sp asm(_ASM_SP);
>
> - /*
> - * If external interrupt exists, IF bit is set in rflags/eflags on the
> - * interrupt stack frame, and interrupt will be enabled on a return
> - * from interrupt handler.
> - */
> if ((exit_intr_info & (INTR_INFO_VALID_MASK | INTR_INFO_INTR_TYPE_MASK))
> == (INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR)) {
> unsigned int vector;
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-13 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-13 2:34 [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr Longpeng(Mike)
2016-10-13 12:36 ` Radim Krčmář
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).