* [PATCH] f2fs: fix wrong sum_page pointer in f2fs_gc
@ 2016-10-12 23:23 Jaegeuk Kim
2016-10-13 10:33 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2016-10-12 23:23 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim
This patch fixes using a wrong pointer for sum_page in f2fs_gc.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/gc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index e48142f..9c18917 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -854,16 +854,16 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
for (segno = start_segno; segno < end_segno; segno++) {
- if (get_valid_blocks(sbi, segno, 1) == 0 ||
- unlikely(f2fs_cp_error(sbi)))
- goto next;
-
/* find segment summary of victim */
sum_page = find_get_page(META_MAPPING(sbi),
GET_SUM_BLOCK(sbi, segno));
- f2fs_bug_on(sbi, !PageUptodate(sum_page));
f2fs_put_page(sum_page, 0);
+ if (get_valid_blocks(sbi, segno, 1) == 0 ||
+ !PageUptodate(sum_page) ||
+ unlikely(f2fs_cp_error(sbi)))
+ goto next;
+
sum = page_address(sum_page);
f2fs_bug_on(sbi, type != GET_SUM_TYPE((&sum->footer)));
--
2.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: fix wrong sum_page pointer in f2fs_gc
2016-10-12 23:23 [PATCH] f2fs: fix wrong sum_page pointer in f2fs_gc Jaegeuk Kim
@ 2016-10-13 10:33 ` Chao Yu
2016-10-13 17:14 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2016-10-13 10:33 UTC (permalink / raw)
To: Jaegeuk Kim, linux-kernel, linux-fsdevel, linux-f2fs-devel
Hi Jaegeuk,
On 2016/10/13 7:23, Jaegeuk Kim wrote:
> This patch fixes using a wrong pointer for sum_page in f2fs_gc.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/gc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index e48142f..9c18917 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -854,16 +854,16 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
>
> for (segno = start_segno; segno < end_segno; segno++) {
>
> - if (get_valid_blocks(sbi, segno, 1) == 0 ||
> - unlikely(f2fs_cp_error(sbi)))
> - goto next;
> -
> /* find segment summary of victim */
> sum_page = find_get_page(META_MAPPING(sbi),
> GET_SUM_BLOCK(sbi, segno));
> - f2fs_bug_on(sbi, !PageUptodate(sum_page));
> f2fs_put_page(sum_page, 0);
>
> + if (get_valid_blocks(sbi, segno, 1) == 0 ||
> + !PageUptodate(sum_page) ||
Why uptodate flag of summary page can be cleared? someone truncates it?
Thanks,
> + unlikely(f2fs_cp_error(sbi)))
> + goto next;
> +
> sum = page_address(sum_page);
> f2fs_bug_on(sbi, type != GET_SUM_TYPE((&sum->footer)));
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: fix wrong sum_page pointer in f2fs_gc
2016-10-13 10:33 ` Chao Yu
@ 2016-10-13 17:14 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2016-10-13 17:14 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-fsdevel, linux-f2fs-devel
On Thu, Oct 13, 2016 at 06:33:19PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2016/10/13 7:23, Jaegeuk Kim wrote:
> > This patch fixes using a wrong pointer for sum_page in f2fs_gc.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/gc.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > index e48142f..9c18917 100644
> > --- a/fs/f2fs/gc.c
> > +++ b/fs/f2fs/gc.c
> > @@ -854,16 +854,16 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi,
> >
> > for (segno = start_segno; segno < end_segno; segno++) {
> >
> > - if (get_valid_blocks(sbi, segno, 1) == 0 ||
> > - unlikely(f2fs_cp_error(sbi)))
> > - goto next;
> > -
> > /* find segment summary of victim */
> > sum_page = find_get_page(META_MAPPING(sbi),
> > GET_SUM_BLOCK(sbi, segno));
> > - f2fs_bug_on(sbi, !PageUptodate(sum_page));
> > f2fs_put_page(sum_page, 0);
> >
> > + if (get_valid_blocks(sbi, segno, 1) == 0 ||
> > + !PageUptodate(sum_page) ||
>
> Why uptodate flag of summary page can be cleared? someone truncates it?
Well, it looks like no problem to remove this, since it will hit
f2fs_cp_error(). I just intended to handle the above f2fs_bug_on here.
I found you added the above bug_on, but it's not a big deal to remain tho. :)
718e53fa: f2fs: enhance foreground GC
Thanks,
>
> Thanks,
>
> > + unlikely(f2fs_cp_error(sbi)))
> > + goto next;
> > +
> > sum = page_address(sum_page);
> > f2fs_bug_on(sbi, type != GET_SUM_TYPE((&sum->footer)));
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 17:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 23:23 [PATCH] f2fs: fix wrong sum_page pointer in f2fs_gc Jaegeuk Kim
2016-10-13 10:33 ` Chao Yu
2016-10-13 17:14 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).