From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Mike Galbraith <efault@gmx.de>,
omer.akram@canonical.com
Subject: Re: [v4.8-rc1 Regression] sched/fair: Apply more PELT fixes
Date: Wed, 19 Oct 2016 13:33:29 +0200 [thread overview]
Message-ID: <20161019113329.GM3102@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20161018115651.GA20956@linaro.org>
On Tue, Oct 18, 2016 at 01:56:51PM +0200, Vincent Guittot wrote:
> ---
> kernel/sched/fair.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8b03fb5..89776ac 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -690,7 +690,14 @@ void init_entity_runnable_average(struct sched_entity *se)
> * will definitely be update (after enqueue).
> */
> sa->period_contrib = 1023;
> - sa->load_avg = scale_load_down(se->load.weight);
> + /*
> + * Tasks are intialized with full load to be seen as heavy task until
> + * they get a chance to stabilize to their real load level.
> + * group entity are intialized with null load to reflect the fact that
> + * nothing has been attached yet to the task group.
> + */
> + if (entity_is_task(se))
> + sa->load_avg = scale_load_down(se->load.weight);
> sa->load_sum = sa->load_avg * LOAD_AVG_MAX;
> /*
> * At this point, util_avg won't be used in select_task_rq_fair anyway
>
Vince, could you post a proper version of this patch with changelogs and
tags so that we can get that merged into Linus' tree and stable for 4.8?
next prev parent reply other threads:[~2016-10-19 16:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 19:38 [v4.8-rc1 Regression] sched/fair: Apply more PELT fixes Joseph Salisbury
2016-10-07 19:57 ` Linus Torvalds
2016-10-07 20:22 ` Joseph Salisbury
2016-10-07 20:37 ` Linus Torvalds
2016-10-08 8:00 ` Peter Zijlstra
2016-10-08 8:39 ` Ingo Molnar
2016-10-08 11:37 ` Vincent Guittot
2016-10-08 11:49 ` Mike Galbraith
2016-10-12 12:20 ` Vincent Guittot
2016-10-12 15:35 ` Joseph Salisbury
2016-10-12 16:21 ` Joseph Salisbury
2016-10-13 10:58 ` Vincent Guittot
2016-10-13 15:52 ` Joseph Salisbury
2016-10-13 16:48 ` Vincent Guittot
2016-10-13 18:49 ` Dietmar Eggemann
2016-10-13 21:34 ` Vincent Guittot
2016-10-14 8:24 ` Vincent Guittot
2016-10-14 13:10 ` Dietmar Eggemann
2016-10-14 15:18 ` Vincent Guittot
2016-10-14 16:04 ` Joseph Salisbury
2016-10-17 9:09 ` Vincent Guittot
2016-10-17 11:49 ` Dietmar Eggemann
2016-10-17 13:19 ` Peter Zijlstra
2016-10-17 13:54 ` Vincent Guittot
2016-10-17 22:52 ` Dietmar Eggemann
2016-10-18 8:43 ` Vincent Guittot
2016-10-18 9:07 ` Peter Zijlstra
2016-10-18 9:45 ` Vincent Guittot
2016-10-18 10:34 ` Peter Zijlstra
2016-10-18 11:56 ` Vincent Guittot
2016-10-18 21:58 ` Joonwoo Park
2016-10-19 6:42 ` Vincent Guittot
2016-10-19 9:46 ` Dietmar Eggemann
2016-10-19 11:25 ` Vincent Guittot
2016-10-19 15:33 ` Dietmar Eggemann
2016-10-19 17:33 ` Joonwoo Park
2016-10-19 17:50 ` Vincent Guittot
2016-10-19 11:33 ` Peter Zijlstra [this message]
2016-10-19 11:50 ` Vincent Guittot
2016-10-19 13:30 ` Morten Rasmussen
2016-10-19 17:41 ` Vincent Guittot
2016-10-20 7:56 ` Morten Rasmussen
2016-10-19 14:49 ` Joseph Salisbury
2016-10-19 14:53 ` Vincent Guittot
2016-10-18 11:15 ` Dietmar Eggemann
2016-10-18 12:07 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019113329.GM3102@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=omer.akram@canonical.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).