* [PATCH] dma: tegra210-adma: convert TEGRA210_ADMA from bool to tristate
@ 2016-10-22 22:25 Paul Gortmaker
2016-11-14 3:41 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2016-10-22 22:25 UTC (permalink / raw)
To: linux-kernel
Cc: Paul Gortmaker, Laxman Dewangan, Jon Hunter, Dan Williams,
Vinod Koul, Stephen Warren, Thierry Reding, Alexandre Courbot,
dmaengine, linux-tegra
This driver currently uses modular infrastructure but is controlled
by a bool Kconfig.
There is a general consensus from the DMA reviewers and maintainers
that "if it can be modular, it should be modular" in order to keep
the bzImage size under control for multi platform kernels.
Build tested only. Also needed some new pm_clk symbols exported
before this commit is applied to tree in order to avoid modpost
errors like:
ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined!
ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined!
ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined!
ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined!
ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined!
These were added as exports in the v4.8-rc1 merge window.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/dma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..4595f5009244 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -479,7 +479,7 @@ config TEGRA20_APB_DMA
or vice versa. It does not support memory to memory data transfer.
config TEGRA210_ADMA
- bool "NVIDIA Tegra210 ADMA support"
+ tristate "NVIDIA Tegra210 ADMA support"
depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST) && PM_CLK
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
--
2.10.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma: tegra210-adma: convert TEGRA210_ADMA from bool to tristate
2016-10-22 22:25 [PATCH] dma: tegra210-adma: convert TEGRA210_ADMA from bool to tristate Paul Gortmaker
@ 2016-11-14 3:41 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-11-14 3:41 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, Laxman Dewangan, Jon Hunter, Dan Williams,
Stephen Warren, Thierry Reding, Alexandre Courbot, dmaengine,
linux-tegra
On Sat, Oct 22, 2016 at 06:25:10PM -0400, Paul Gortmaker wrote:
> This driver currently uses modular infrastructure but is controlled
> by a bool Kconfig.
>
> There is a general consensus from the DMA reviewers and maintainers
> that "if it can be modular, it should be modular" in order to keep
> the bzImage size under control for multi platform kernels.
>
> Build tested only. Also needed some new pm_clk symbols exported
> before this commit is applied to tree in order to avoid modpost
> errors like:
>
> ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined!
>
> These were added as exports in the v4.8-rc1 merge window.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-14 3:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-22 22:25 [PATCH] dma: tegra210-adma: convert TEGRA210_ADMA from bool to tristate Paul Gortmaker
2016-11-14 3:41 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).