* [PATCH] drm/panel: simple: Check against num_timings when setting preferred for timing
@ 2016-10-24 13:21 Chen-Yu Tsai
2016-12-06 15:52 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Tsai @ 2016-10-24 13:21 UTC (permalink / raw)
To: Thierry Reding, David Airlie; +Cc: Chen-Yu Tsai, dri-devel, linux-kernel
In the loop on .timings, we should check .num_timings to see if it's the
only mode specified, not .num_modes, which should be used with .modes.
Fixes: cda553725c92 ("drm/panel: simple: Set appropriate mode type")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
drivers/gpu/drm/panel/panel-simple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 113db3c4a633..27cb42467b20 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -120,7 +120,7 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
mode->type |= DRM_MODE_TYPE_DRIVER;
- if (panel->desc->num_modes == 1)
+ if (panel->desc->num_timings == 1)
mode->type |= DRM_MODE_TYPE_PREFERRED;
drm_mode_probed_add(connector, mode);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panel: simple: Check against num_timings when setting preferred for timing
2016-10-24 13:21 [PATCH] drm/panel: simple: Check against num_timings when setting preferred for timing Chen-Yu Tsai
@ 2016-12-06 15:52 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2016-12-06 15:52 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: David Airlie, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Mon, Oct 24, 2016 at 09:21:15PM +0800, Chen-Yu Tsai wrote:
> In the loop on .timings, we should check .num_timings to see if it's the
> only mode specified, not .num_modes, which should be used with .modes.
>
> Fixes: cda553725c92 ("drm/panel: simple: Set appropriate mode type")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-06 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 13:21 [PATCH] drm/panel: simple: Check against num_timings when setting preferred for timing Chen-Yu Tsai
2016-12-06 15:52 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).