From: Lukasz Majewski <l.majewski@majess.pl>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Stefan Agner <stefan@agner.ch>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Lothar Wassmann <LW@karo-electronics.de>,
Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 6/6] pwm: imx: Introduce "polarity_supported" flag to PWMv2 driver
Date: Mon, 24 Oct 2016 23:14:58 +0200 [thread overview]
Message-ID: <20161024231458.075ea50b@jawa> (raw)
In-Reply-To: <20161024173410.6e641b9c@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 2925 bytes --]
Hi Boris,
> On Mon, 24 Oct 2016 17:28:52 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
> > On Sun, 23 Oct 2016 23:45:46 +0200
> > Lukasz Majewski <l.majewski@majess.pl> wrote:
> >
> > > The need for set_polarity() function has been removed by
> > > implementing PWM atomic support (apply() callback).
> > >
> > > To indicate that the PWMv2 supports polarity inversion, new flag -
> > > "polarity_supported" has been introduced.
> > >
> > > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
> > > ---
> > > drivers/pwm/pwm-imx.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> > > index 02d3dfd..be3034d 100644
> > > --- a/drivers/pwm/pwm-imx.c
> > > +++ b/drivers/pwm/pwm-imx.c
> > > @@ -258,6 +258,7 @@ static struct pwm_ops imx_pwm_ops_v2 = {
> > > };
> > >
> > > struct imx_pwm_data {
> > > + bool polarity_supported;
> > > struct pwm_ops *pwm_ops;
> > > };
> > >
> > > @@ -266,6 +267,7 @@ static struct imx_pwm_data imx_pwm_data_v1 = {
> > > };
> > >
> > > static struct imx_pwm_data imx_pwm_data_v2 = {
> > > + .polarity_supported = true,
> > > .pwm_ops = &imx_pwm_ops_v2,
> > > };
> > >
> > > @@ -313,7 +315,7 @@ static int imx_pwm_probe(struct
> > > platform_device *pdev) imx->chip.base = -1;
> > > imx->chip.npwm = 1;
> > > imx->chip.can_sleep = true;
> > > - if (data->pwm_ops->set_polarity) {
> > > + if (data->polarity_supported) {
> >
> > You're still breaking backward compatibility with DTs defining
> > #pwm-cells = 2.
> >
> > Please test the #pwm-cells value before deciding which of_xlate
> > should be used.
>
> Nevermind, I didn't look at [1] and [2].
Yes, some patches are required to make this code work. Especially, I
wanted to explicitly reuse and credit work already done by
Bhuvanchandra.
> But still, your series is not bisectable: this change should be part
> of patch 5 where you remove the ->set_polarity implementation.
> Otherwise, this means you don't support polarity setting between
> patch 5 and 6.
Frankly speaking, I did it on purpose, to have operations in commits
logically separated.
I personally, do detest commits which blur the picture and are not
corresponding to one single logical change - for example remove some
large chunk of code and also add some tiny, new flag.
For me it is not a problem to have polarity disabled between patches 5
and 6, since at the end of the day we have it enabled.
Thanks for your support and review,
Best regards,
Łukasz Majewski
>
> >
> > > dev_dbg(&pdev->dev, "PWM supports output
> > > inversion\n"); imx->chip.of_xlate = of_pwm_xlate_with_flags;
> > > imx->chip.of_pwm_n_cells = 3;
> >
>
> [1]http://patchwork.ozlabs.org/patch/679706/
> [2]http://patchwork.ozlabs.org/patch/679707/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-10-24 21:22 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 21:45 [PATCH 0/6] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski
2016-10-23 21:45 ` [PATCH 1/6] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski
2016-10-24 15:21 ` Boris Brezillon
2016-10-25 5:54 ` Sascha Hauer
2016-10-25 6:27 ` Boris Brezillon
2016-10-25 6:32 ` Sascha Hauer
2016-10-25 6:42 ` Boris Brezillon
2016-10-25 6:55 ` Lukasz Majewski
2016-10-23 21:45 ` [PATCH 2/6] pwm: imx: Move PWMv2 software reset code to a separate function Lukasz Majewski
2016-10-24 15:23 ` Boris Brezillon
2016-10-24 21:02 ` Lukasz Majewski
2016-10-23 21:45 ` [PATCH 3/6] pwm: imx: Move PWMv2 wait for fifo slot " Lukasz Majewski
2016-10-24 15:23 ` Boris Brezillon
2016-10-23 21:45 ` [PATCH 4/6] pwm: imx: Provide atomic PWM support for IMXv2 PWM Lukasz Majewski
2016-10-24 15:25 ` Boris Brezillon
2016-10-23 21:45 ` [PATCH 5/6] pwm: imx: Remove redundant IMX PWMv2 code Lukasz Majewski
2016-10-24 15:27 ` Boris Brezillon
2016-10-23 21:45 ` [PATCH 6/6] pwm: imx: Introduce "polarity_supported" flag to PWMv2 driver Lukasz Majewski
2016-10-24 15:28 ` Boris Brezillon
2016-10-24 15:34 ` Boris Brezillon
2016-10-24 21:14 ` Lukasz Majewski [this message]
2016-10-25 6:37 ` Boris Brezillon
2016-10-25 6:58 ` Lukasz Majewski
2016-10-24 15:36 ` [PATCH 0/6] pwm: imx: Provide atomic operation for IMX PWM driver Boris Brezillon
2016-10-24 21:26 ` Lukasz Majewski
2016-10-25 3:41 ` Stefan Agner
2016-10-25 7:07 ` Lukasz Majewski
2016-10-25 17:08 ` Fabio Estevam
2016-10-25 17:09 ` Fabio Estevam
2016-10-27 5:59 ` Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 00/11] " Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 01/11] pwm: print error messages with pr_err() instead of pr_debug() Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 02/11] pwm: imx: remove ipg clock Lukasz Majewski
2016-12-27 7:26 ` Stefan Agner
2016-12-27 7:54 ` Lukasz Majewski
2016-12-28 22:01 ` Lukasz Majewski
2016-12-29 7:22 ` Stefan Agner
2016-12-29 10:06 ` Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 03/11] pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2 Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 04/11] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 05/11] pwm: imx: Move PWMv2 software reset code to a separate function Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 06/11] pwm: imx: Move PWMv2 wait for fifo slot " Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski
2016-12-29 16:21 ` Boris Brezillon
2016-12-29 16:45 ` Lukasz Majewski
2016-12-29 17:08 ` Boris Brezillon
2017-01-03 11:43 ` Lukasz Majewski
2017-01-03 12:46 ` Boris Brezillon
2017-01-03 17:29 ` Stefan Agner
2017-01-03 19:35 ` Boris Brezillon
2017-01-03 22:01 ` Lukasz Majewski
2017-01-03 22:18 ` Boris Brezillon
2017-01-03 22:46 ` Lukasz Majewski
2017-01-03 23:34 ` Boris Brezillon
2017-01-04 11:29 ` Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 08/11] pwm: imx: Remove redundant i.MX PWMv2 code Lukasz Majewski
2016-12-26 22:55 ` [PATCH v3 RESEND 09/11] pwm: core: make the PWM_POLARITY flag in DTB optional Lukasz Majewski
2016-12-26 22:56 ` [PATCH v3 RESEND 10/11] pwm: imx: doc: Update imx-pwm.txt documentation entry Lukasz Majewski
2016-12-26 22:56 ` [PATCH v3 RESEND 11/11] pwm: imx: Add polarity inversion support to i.MX's PWMv2 Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024231458.075ea50b@jawa \
--to=l.majewski@majess.pl \
--cc=LW@karo-electronics.de \
--cc=bhuvanchandra.dv@toradex.com \
--cc=boris.brezillon@free-electrons.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).