tpm_tis regression in 4.9?

tpm_tis regression in 4.9?

[Andy Lutomirski]

Hi-

I think this error on my laptop is new on 4.9 kernels:

[  +0.014696] tpm_tis 00:09: 1.2 TPM (device-id 0xFE, rev-id 2)
[  +0.012228] tpm tpm0: TPM self test failed
[  +0.000019] tpm_tis: probe of 00:09 failed with error -14

Is this known?

At the very least, shouldn't the error message include rc?

--Andy

Re: tpm_tis regression in 4.9?

[Jason Gunthorpe]

On Thu, Oct 27, 2016 at 05:33:57PM -0700, Andy Lutomirski wrote:
> Hi-
> 
> I think this error on my laptop is new on 4.9 kernels:
> 
> [  +0.014696] tpm_tis 00:09: 1.2 TPM (device-id 0xFE, rev-id 2)
> [  +0.012228] tpm tpm0: TPM self test failed
> [  +0.000019] tpm_tis: probe of 00:09 failed with error -14
> 
> Is this known?

I think this patch from Jarkko's next is the fix:

http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7ddcdd8990e4783d09c7e86d90ccb4121

Jarkko? Can you hurry that along to go in for -rc?

> At the very least, shouldn't the error message include rc?

Yes.

Thanks,
Jason

Re: tpm_tis regression in 4.9?

[Jarkko Sakkinen]

On Thu, Oct 27, 2016 at 05:33:57PM -0700, Andy Lutomirski wrote:
> Hi-
> 
> I think this error on my laptop is new on 4.9 kernels:
> 
> [  +0.014696] tpm_tis 00:09: 1.2 TPM (device-id 0xFE, rev-id 2)
> [  +0.012228] tpm tpm0: TPM self test failed
> [  +0.000019] tpm_tis: probe of 00:09 failed with error -14
> 
> Is this known?
> 
> At the very least, shouldn't the error message include rc?

It is known:

http://www.spinics.net/lists/kernel/msg2356176.html

> --Andy

/Jarkko

Re: tpm_tis regression in 4.9?

[Jarkko Sakkinen]

On Thu, Oct 27, 2016 at 09:09:16PM -0600, Jason Gunthorpe wrote: > On Thu, Oct 27, 2016 at 05:33:57PM -0700, Andy Lutomirski wrote:
> > Hi-
> > 
> > I think this error on my laptop is new on 4.9 kernels:
> > 
> > [  +0.014696] tpm_tis 00:09: 1.2 TPM (device-id 0xFE, rev-id 2)
> > [  +0.012228] tpm tpm0: TPM self test failed
> > [  +0.000019] tpm_tis: probe of 00:09 failed with error -14
> > 
> > Is this known?
> 
> I think this patch from Jarkko's next is the fix:
> 
> http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7ddcdd8990e4783d09c7e86d90ccb4121
> 
> Jarkko? Can you hurry that along to go in for -rc?

Do you think I should resend the pull request?

/Jarkko

Re: tpm_tis regression in 4.9?

[Jason Gunthorpe]

On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote:

> > I think this patch from Jarkko's next is the fix:
> > 
> > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7ddcdd8990e4783d09c7e86d90ccb4121
> > 
> > Jarkko? Can you hurry that along to go in for -rc?
> 
> Do you think I should resend the pull request?

That or a ping. This patch needs to land right away since it is breaking 4.9.

Jason

Re: tpm_tis regression in 4.9?

[Thorsten Leemhuis]

FYI: I added this report to the list of regressions for Linux 4.9. I'll
watch this thread for further updates on this issue to document progress
in my weekly reports. Please let me know via regressions@leemhuis.info
in case the discussion moves to a different place (bugzilla or another
mail thread for example). But FWIW: I already know this is discussed in
at least two other places:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256705.html
https://www.spinics.net/lists/kernel/msg2372189.html

tia! Ciao, Thorsten

On 28.10.2016 19:10, Jason Gunthorpe wrote:
> On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote:
> 
>>> I think this patch from Jarkko's next is the fix:
>>>
>>> http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7ddcdd8990e4783d09c7e86d90ccb4121
>>>
>>> Jarkko? Can you hurry that along to go in for -rc?
>>
>> Do you think I should resend the pull request?
> 
> That or a ping. This patch needs to land right away since it is breaking 4.9.
> 
> Jason
> 
> http://news.gmane.org/find-root.php?message_id=20161028171043.GA18206%40obsidianresearch.com 
> http://mid.gmane.org/20161028171043.GA18206%40obsidianresearch.com
> 

RE: [tpmdd-devel] tpm_tis regression in 4.9?

[Winkler, Tomas]

> 
> On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote:
> 
> > > I think this patch from Jarkko's next is the fix:
> > >
> > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7dd
> > > cdd8990e4783d09c7e86d90ccb4121
> > >
> > > Jarkko? Can you hurry that along to go in for -rc?
> >
> > Do you think I should resend the pull request?
> 
> That or a ping. This patch needs to land right away since it is breaking 4.9.
> 
> Jason

Jarrko, why we didn't request pull for fix Intel PTT patches, as well for 4.9? 
Thanks
Tomas

Re: [tpmdd-devel] tpm_tis regression in 4.9?

[Jarkko Sakkinen]

On Mon, Oct 31, 2016 at 08:16:59PM +0000, Winkler, Tomas wrote:
> > 
> > On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote:
> > 
> > > > I think this patch from Jarkko's next is the fix:
> > > >
> > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7dd
> > > > cdd8990e4783d09c7e86d90ccb4121
> > > >
> > > > Jarkko? Can you hurry that along to go in for -rc?
> > >
> > > Do you think I should resend the pull request?
> > 
> > That or a ping. This patch needs to land right away since it is breaking 4.9.
> > 
> > Jason
> 
> Jarrko, why we didn't request pull for fix Intel PTT patches, as well for 4.9? 

Which patches are you talking about?

/Jarkko

RE: [tpmdd-devel] tpm_tis regression in 4.9?

[Winkler, Tomas]

> 
> On Mon, Oct 31, 2016 at 08:16:59PM +0000, Winkler, Tomas wrote:
> > >
> > > On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote:
> > >
> > > > > I think this patch from Jarkko's next is the fix:
> > > > >
> > > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7dd
> > > > > cdd8990e4783d09c7e86d90ccb4121
> > > > >
> > > > > Jarkko? Can you hurry that along to go in for -rc?
> > > >
> > > > Do you think I should resend the pull request?
> > >
> > > That or a ping. This patch needs to land right away since it is breaking 4.9.
> > >
> > > Jason
> >
> > Jarrko, why we didn't request pull for fix Intel PTT patches, as well for 4.9?
> 
> Which patches are you talking about?

213ebc81ac3f tmp/tpm_crb: implement runtime pm for tpm_crb
a0cb67590dff tpm/tpm_crb: open code the crb_init into acpi_add
4d73afd9c0fd tmp/tpm_crb: fix Intel PTT hw bug during idle state
34483fbffd83 tpm/tpm_crb: implement tpm crb idle state

Thanks
Tomas 

Re: [tpmdd-devel] tpm_tis regression in 4.9?

[Jarkko Sakkinen]

On Tue, Nov 01, 2016 at 08:56:47PM +0000, Winkler, Tomas wrote:
> > 
> > On Mon, Oct 31, 2016 at 08:16:59PM +0000, Winkler, Tomas wrote:
> > > >
> > > > On Fri, Oct 28, 2016 at 05:37:45PM +0300, Jarkko Sakkinen wrote:
> > > >
> > > > > > I think this patch from Jarkko's next is the fix:
> > > > > >
> > > > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/65da72b7dd
> > > > > > cdd8990e4783d09c7e86d90ccb4121
> > > > > >
> > > > > > Jarkko? Can you hurry that along to go in for -rc?
> > > > >
> > > > > Do you think I should resend the pull request?
> > > >
> > > > That or a ping. This patch needs to land right away since it is breaking 4.9.
> > > >
> > > > Jason
> > >
> > > Jarrko, why we didn't request pull for fix Intel PTT patches, as well for 4.9?
> > 
> > Which patches are you talking about?
> 
> 213ebc81ac3f tmp/tpm_crb: implement runtime pm for tpm_crb
> a0cb67590dff tpm/tpm_crb: open code the crb_init into acpi_add
> 4d73afd9c0fd tmp/tpm_crb: fix Intel PTT hw bug during idle state
> 34483fbffd83 tpm/tpm_crb: implement tpm crb idle state

I can propose these to the stable series. Not having power gating is not
a kernel regression but important enough for the stable IMHO.

I wonder what is the process of proposing something to stable if you do
not have a commit ID for regression?

> Thanks
> Tomas

/Jarkko