linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Michal Necasek <michal.necasek@oracle.com>,
	prarit@redhat.com, ville.syrjala@linux.intel.com,
	michael.thayer@oracle.com, knut.osmundsen@oracle.com,
	frank.mehnert@oracle.com, linux-kernel@vger.kernel.org,
	wbauer@tmo.at
Subject: Re: 4.8.2 not booting in 32-bit VM without I/O-APIC
Date: Sat, 29 Oct 2016 12:18:07 +0200	[thread overview]
Message-ID: <20161029101807.5eqyuka6mjuqd2kw@pd.tnic> (raw)
In-Reply-To: <alpine.DEB.2.20.1610282114380.5053@nanos>

On Fri, Oct 28, 2016 at 09:34:53PM +0200, Thomas Gleixner wrote:
> Right. That mapping setup is an utter trainwreck as we do it from multiple
> places, but there is no reason why we can't move it before the call to
> prefill_possible_map().

> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index bbfbca5fea0c..b59fdba3cbdf 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -1221,11 +1221,13 @@ void __init setup_arch(char **cmdline_p)
>  	 */
>  	get_smp_config();
>  
> +	/* Make sure apic is mapped before prefill_possible_map() */
> +	init_apic_mappings();
> +
>  	prefill_possible_map();
>  
>  	init_cpu_to_node();
>  
> -	init_apic_mappings();
>  	io_apic_init_mappings();
>  
>  	kvm_guest_init();

FWIW, I got another user's confirmation that this works with his
virtual box:

https://bugzilla.suse.com/show_bug.cgi?id=1006417#c32
https://bugzilla.suse.com/show_bug.cgi?id=1006417#c33

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

  reply	other threads:[~2016-10-29 10:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 18:52 4.8.2 not booting in 32-bit VM without I/O-APIC Michal Necasek
2016-10-28 19:00 ` Thomas Gleixner
2016-10-28 19:34   ` Thomas Gleixner
2016-10-29 10:18     ` Borislav Petkov [this message]
2016-10-29 12:04     ` [tip:x86/urgent] x86/smpboot: Init apic mapping before usage tip-bot for Thomas Gleixner
2016-10-29 12:06     ` tip-bot for Thomas Gleixner
  -- strict thread matches above, loose matches on Subject: below --
2016-11-03 20:02 4.8.2 not booting in 32-bit VM without I/O-APIC Michal Necasek
2016-11-10 14:21 ` Michael Thayer
2016-11-10 17:18   ` Thomas Gleixner
2016-10-28 18:30 Michal Necasek
2016-10-28 18:38 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161029101807.5eqyuka6mjuqd2kw@pd.tnic \
    --to=bp@alien8.de \
    --cc=frank.mehnert@oracle.com \
    --cc=knut.osmundsen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    --cc=michal.necasek@oracle.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wbauer@tmo.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).