linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Axel Haslam <ahaslam@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Kevin Hilman <khilman@baylibre.com>, Sekhar Nori <nsekhar@ti.com>,
	David Lechner <david@lechnology.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] regulator: core: Add over current changed event
Date: Sat, 29 Oct 2016 12:40:31 -0600	[thread overview]
Message-ID: <20161029184031.adjybckguxzfu3pq@sirena.org.uk> (raw)
In-Reply-To: <CAKXjFTNtcdTQJ_Gee87NTv3_RZscVjg4UWLkLVCZFE-TrXfsxQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

On Fri, Oct 28, 2016 at 09:41:44PM +0200, Axel Haslam wrote:

> i think today each time an event occurs a notification is sent with the
> corresponding flag(s) set.

Right, so I think the problem here is actually that you called this 
REGULATOR_EVENT_OVER_CURRENT_CHANGE with the _CHANGE on the end which
means it's just saying that the user has to go poll to see if the device
is or is not over current separately at which point you may as well pull
in all the other error things into what you're polling for.  If you'd
dropped the _CHANGE it'd be consistent with the other events we have for
errors and fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

  parent reply	other threads:[~2016-10-29 18:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 19:00 [PATCH 0/3] regulator: Send events on over current condition ahaslam
2016-10-26 19:00 ` [RFC 1/3] regulator: core: Add over current changed event ahaslam
2016-10-28 18:22   ` Mark Brown
2016-10-28 19:41     ` Axel Haslam
2016-10-29  8:50       ` Axel Haslam
2016-10-29 18:40       ` Mark Brown [this message]
2016-10-30 12:02         ` Axel Haslam
2016-10-31 16:22           ` Mark Brown
2016-11-01 15:47             ` Axel Haslam
2016-10-26 19:00 ` [RFC 2/3] regulator: fixed: Handle optional overcurrent pin ahaslam
2016-10-26 19:00 ` [RFC 3/3] regulator: fixed: dt: Allow an optional over current pin ahaslam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161029184031.adjybckguxzfu3pq@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ahaslam@baylibre.com \
    --cc=david@lechnology.com \
    --cc=khilman@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).