* RFC if==else in i40iw_virtchnl.
@ 2016-10-30 12:33 Nicholas Mc Guire
0 siblings, 0 replies; only message in thread
From: Nicholas Mc Guire @ 2016-10-30 12:33 UTC (permalink / raw)
To: Faisal Latif; +Cc: linux-rdma, linux-kernel
Hi Faisal !
your commit 4097351a47c5 ("i40iw: virtual channel handling files")
adds the following lines in i40iw_vchnl_recv_pf()
+ if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0)
+ vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
+ else
+ vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
+ return I40IW_SUCCESS;
as the if==else here this looks buggy - if it is intended it atleast needs
a comment/explaination but it did not seem to make much sense in this
form (Note this is the only place where vchnl_pf_send_get_ver_resp() is
being called so the intent is not clear from code review and thus no patch
can be resonably suggested.
thx!
hofrat
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-30 12:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-30 12:33 RFC if==else in i40iw_virtchnl Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).