linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/9] s390: remove modular usage from non-modular code
@ 2016-10-30 20:37 Paul Gortmaker
  2016-10-30 20:37 ` [PATCH 1/9] s390: cio: make it explicitly non-modular Paul Gortmaker
                   ` (9 more replies)
  0 siblings, 10 replies; 12+ messages in thread
From: Paul Gortmaker @ 2016-10-30 20:37 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paul Gortmaker, Arnd Bergmann, Bjorn Helgaas,
	Christian Borntraeger, Cornelia Huck, Gerald Schaefer,
	Heiko Carstens, linux-s390, Martin Schwidefsky,
	Peter Oberparleiter, Sebastian Ott

My ongoing audit looking for non-modular code that needlessly uses
modular macros (vs. built-in equivalents) and/or has dead code
relating to module unloading that can never be executed led to the
creation of these s390 related commits.

For anyone new to the underlying goal of this cleanup, we are trying to
not use module support for code that can never be built as a module since:

 (1) it is easy to accidentally write unused module_exit and remove code
 (2) it can be misleading when reading the source, thinking it can be
     modular when the Makefile and/or Kconfig prohibit it
 (3) it requires the include of the module.h header file which in turn
     includes nearly everything else, thus adding to CPP overhead.
 (4) it gets copied/replicated into other code and spreads like weeds.

Build tested on current linux-next (allyes/allno/allmod) to ensure no
silly typos or implicit include issues that would break compilation
crept in.

---

Cc: Arnd Bergmann <arndb@de.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>

Paul Gortmaker (9):
  s390: cio: make it explicitly non-modular
  s390: char: make zcore explicitly non-modular
  s390: char: make con3215 explicitly non-modular
  s390: char: make sclp_tty explicitly non-modular
  s390: char: make slcp_quiesce explicitly non-modular
  s390: hotplug: make pci_hpc explicitly non-modular
  s390: hypfs: make inode explicitly non-modular
  s390: kernel: make lgr explicitly non-modular
  s390: virtio: make ccw explicitly non-modular

 arch/s390/hypfs/inode.c            | 24 ++++--------------------
 arch/s390/kernel/lgr.c             |  5 +++--
 drivers/pci/hotplug/s390_pci_hpc.c |  7 ++-----
 drivers/s390/char/con3215.c        | 12 +-----------
 drivers/s390/char/sclp_quiesce.c   |  4 +---
 drivers/s390/char/sclp_tty.c       |  3 +--
 drivers/s390/char/zcore.c          | 20 +-------------------
 drivers/s390/cio/cmf.c             | 10 ++--------
 drivers/s390/cio/css.c             |  6 +++---
 drivers/s390/cio/device.c          |  6 +++---
 drivers/s390/cio/device_ops.c      |  5 +++--
 drivers/s390/virtio/virtio_ccw.c   | 25 ++-----------------------
 12 files changed, 26 insertions(+), 101 deletions(-)

-- 
2.10.1

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-10-31 10:56 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-30 20:37 [PATCH 0/9] s390: remove modular usage from non-modular code Paul Gortmaker
2016-10-30 20:37 ` [PATCH 1/9] s390: cio: make it explicitly non-modular Paul Gortmaker
2016-10-30 20:37 ` [PATCH 2/9] s390: char: make zcore " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 3/9] s390: char: make con3215 " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 4/9] s390: char: make sclp_tty " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 5/9] s390: char: make slcp_quiesce " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 6/9] s390: hotplug: make pci_hpc " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 7/9] s390: hypfs: make inode " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 8/9] s390: kernel: make lgr " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 9/9] s390: virtio: make ccw " Paul Gortmaker
2016-10-31 10:56   ` Cornelia Huck
2016-10-31  9:24 ` [PATCH 0/9] s390: remove modular usage from non-modular code Heiko Carstens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).