linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Sean Young <sean@mess.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver
Date: Fri, 04 Nov 2016 13:28:38 +0900	[thread overview]
Message-ID: <20161104042838.kwjv66ldun6g4hlv@gangnam.samsung> (raw)
In-Reply-To: <70e31ed5-e1ec-cac3-3c3d-02c75f1418bd@samsung.com>

Hi Jacek,

> > > Only DT bindings of LED class drivers should be placed in
> > > Documentation/devicetree/bindings/leds. Please move it to the
> > > media bindings.
> > 
> > that's where I placed it first, but Rob asked me to put it in the
> > LED directory and Cc the LED mailining list.
> > 
> > That's the discussion of the version 2:
> > 
> > https://lkml.org/lkml/2016/9/12/380
> > 
> > Rob, Jacek, could you please agree where I can put the binding?
> 
> I'm not sure if this is a good approach. I've noticed also that
> backlight bindings have been moved to leds, whereas they don't look
> similarly.
> 
> We have common.txt LED bindings, that all LED class drivers' bindings
> have to follow. Neither backlight bindings nor these ones do that,
> which introduces some mess.
> 
> Eventually adding a sub-directory, e.g. remote_control could make it
> somehow logically justified, but still - shouldn't bindings be
> placed in the documentation directory related to the subsystem of the
> driver they are predestined to?

In principle I agree with you, also because I understood that the
led kind of bindings are for those LEDs which main function is to
emit light.

There is no need for a remote control directory, because there is
one already under bindings/media, where all the remote
controllers are placed.

Now this is a matter of interpretation, is this an IR LED used by
the driver as remote controller or is this a remote controller
with just an IR LED?

In any case, I will wait for you and Rob to agree where is best
to place the binding, then I will send a new version.

Thanks,
Andi

  reply	other threads:[~2016-11-04  4:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 10:40 [PATCH v3 0/6] Add support for IR transmitters Andi Shyti
2016-11-02 10:40 ` [PATCH v3 1/6] [media] rc-main: assign driver type during allocation Andi Shyti
2016-11-02 10:40 ` [PATCH v3 2/6] [media] rc-main: split setup and unregister functions Andi Shyti
2016-11-02 10:40 ` [PATCH v3 3/6] [media] rc-core: add support for IR raw transmitters Andi Shyti
2016-11-02 12:34   ` kbuild test robot
2016-11-02 10:40 ` [PATCH v3 4/6] [media] rc-ir-raw: do not generate any receiving thread for " Andi Shyti
2016-11-02 10:40 ` [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver Andi Shyti
2016-11-03  8:32   ` Jacek Anaszewski
2016-11-03 10:10     ` Andi Shyti
2016-11-03 10:39       ` Jacek Anaszewski
2016-11-04  4:28         ` Andi Shyti [this message]
2016-11-09 18:26         ` Rob Herring
2016-11-10  7:46           ` Jacek Anaszewski
2016-11-10 10:02             ` Andi Shyti
2016-11-14 16:10               ` Rob Herring
2016-11-02 10:40 ` [PATCH v3 6/6] [media] rc: add support for IR LEDs driven through SPI Andi Shyti
2016-11-02 17:29 ` [PATCH v3 0/6] Add support for IR transmitters Sean Young
2016-11-02 19:57 ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161104042838.kwjv66ldun6g4hlv@gangnam.samsung \
    --to=andi.shyti@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j.anaszewski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@osg.samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).