* [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string
@ 2016-11-05 14:25 Heinrich Schuchardt
2016-11-07 9:02 ` Patrice Chotard
2016-11-08 10:26 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2016-11-05 14:25 UTC (permalink / raw)
To: Patrice Chotard, Linus Walleij
Cc: linux-arm-kernel, kernel, linux-gpio, linux-kernel, Heinrich Schuchardt
function is defined as unsigned int.
So we need %u to print it.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/pinctrl/pinctrl-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index b7bb371..8308f15 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1006,7 +1006,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev,
function = st_pctl_get_pin_function(pc, offset);
if (function)
- snprintf(f, 10, "Alt Fn %d", function);
+ snprintf(f, 10, "Alt Fn %u", function);
else
snprintf(f, 5, "GPIO");
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string
2016-11-05 14:25 [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string Heinrich Schuchardt
@ 2016-11-07 9:02 ` Patrice Chotard
2016-11-08 10:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Patrice Chotard @ 2016-11-07 9:02 UTC (permalink / raw)
To: Heinrich Schuchardt, Linus Walleij
Cc: linux-arm-kernel, kernel, linux-gpio, linux-kernel
On 11/05/2016 03:25 PM, Heinrich Schuchardt wrote:
> function is defined as unsigned int.
> So we need %u to print it.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/pinctrl/pinctrl-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index b7bb371..8308f15 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1006,7 +1006,7 @@ static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev,
>
> function = st_pctl_get_pin_function(pc, offset);
> if (function)
> - snprintf(f, 10, "Alt Fn %d", function);
> + snprintf(f, 10, "Alt Fn %u", function);
> else
> snprintf(f, 5, "GPIO");
>
>
Hi Heinrich
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string
2016-11-05 14:25 [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string Heinrich Schuchardt
2016-11-07 9:02 ` Patrice Chotard
@ 2016-11-08 10:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-11-08 10:26 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Patrice Chotard, linux-arm-kernel,
open list:ARM/STI ARCHITECTURE, linux-gpio, linux-kernel
On Sat, Nov 5, 2016 at 3:25 PM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> function is defined as unsigned int.
> So we need %u to print it.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-08 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-05 14:25 [PATCH 1/1] pinctrl: st: st_pinconf_dbg_show wrong format string Heinrich Schuchardt
2016-11-07 9:02 ` Patrice Chotard
2016-11-08 10:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).