* [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()
@ 2016-11-02 17:21 Masahiro Yamada
2016-11-05 7:26 ` Marek Vasut
2016-11-06 22:55 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2016-11-02 17:21 UTC (permalink / raw)
To: linux-mtd
Cc: Enrico Jorns, Jingoo Han, Sachin Kamat, Boris Brezillon,
Andy Shevchenko, Graham Moore, Stephen Boyd, Dinh Nguyen,
Masahiro Yamada, linux-kernel, Brian Norris, Richard Weinberger,
David Woodhouse
The denali_dt_probe() calls clk_disable_unprepare() in the bailout
path, whereas denali_dt_remove calls clk_disable(), inconsistently.
Replace the latter with clk_disable_unprepare() to make sure to
unprepare the clock.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mtd/nand/denali_dt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
index 0cb1e8d..f821dc1 100644
--- a/drivers/mtd/nand/denali_dt.c
+++ b/drivers/mtd/nand/denali_dt.c
@@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev)
struct denali_dt *dt = platform_get_drvdata(ofdev);
denali_remove(&dt->denali);
- clk_disable(dt->clk);
+ clk_disable_unprepare(dt->clk);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()
2016-11-02 17:21 [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() Masahiro Yamada
@ 2016-11-05 7:26 ` Marek Vasut
2016-11-06 22:55 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2016-11-05 7:26 UTC (permalink / raw)
To: Masahiro Yamada, linux-mtd
Cc: Boris Brezillon, Stephen Boyd, Brian Norris, Sachin Kamat,
Richard Weinberger, Jingoo Han, linux-kernel, Andy Shevchenko,
Enrico Jorns, David Woodhouse, Dinh Nguyen, Graham Moore
On 11/02/2016 06:21 PM, Masahiro Yamada wrote:
> The denali_dt_probe() calls clk_disable_unprepare() in the bailout
> path, whereas denali_dt_remove calls clk_disable(), inconsistently.
> Replace the latter with clk_disable_unprepare() to make sure to
> unprepare the clock.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>
> drivers/mtd/nand/denali_dt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 0cb1e8d..f821dc1 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev)
> struct denali_dt *dt = platform_get_drvdata(ofdev);
>
> denali_remove(&dt->denali);
> - clk_disable(dt->clk);
> + clk_disable_unprepare(dt->clk);
>
> return 0;
> }
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()
2016-11-02 17:21 [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() Masahiro Yamada
2016-11-05 7:26 ` Marek Vasut
@ 2016-11-06 22:55 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2016-11-06 22:55 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-mtd, Enrico Jorns, Jingoo Han, Sachin Kamat,
Andy Shevchenko, Graham Moore, Stephen Boyd, Dinh Nguyen,
linux-kernel, Brian Norris, Richard Weinberger, David Woodhouse
On Thu, 3 Nov 2016 02:21:04 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> The denali_dt_probe() calls clk_disable_unprepare() in the bailout
> path, whereas denali_dt_remove calls clk_disable(), inconsistently.
> Replace the latter with clk_disable_unprepare() to make sure to
> unprepare the clock.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied.
Thanks,
Boris
> ---
>
> drivers/mtd/nand/denali_dt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 0cb1e8d..f821dc1 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev)
> struct denali_dt *dt = platform_get_drvdata(ofdev);
>
> denali_remove(&dt->denali);
> - clk_disable(dt->clk);
> + clk_disable_unprepare(dt->clk);
>
> return 0;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-06 22:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-02 17:21 [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() Masahiro Yamada
2016-11-05 7:26 ` Marek Vasut
2016-11-06 22:55 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).