* [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>
@ 2016-11-07 15:58 Masahiro Yamada
2016-11-07 16:14 ` Russell King - ARM Linux
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2016-11-07 15:58 UTC (permalink / raw)
To: patches; +Cc: Masahiro Yamada, linux-arm-kernel, Russell King, linux-kernel
Nothing in this header file depends on <linux/types.h>.
Rather, <linux/errno.h> should be included for -ENODEV.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
KernelVersion: 4.9-rc1
arch/arm/include/asm/hardware/cache-uniphier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/hardware/cache-uniphier.h b/arch/arm/include/asm/hardware/cache-uniphier.h
index eaa60da..0ef42ae 100644
--- a/arch/arm/include/asm/hardware/cache-uniphier.h
+++ b/arch/arm/include/asm/hardware/cache-uniphier.h
@@ -16,7 +16,7 @@
#ifndef __CACHE_UNIPHIER_H
#define __CACHE_UNIPHIER_H
-#include <linux/types.h>
+#include <linux/errno.h>
#ifdef CONFIG_CACHE_UNIPHIER
int uniphier_cache_init(void);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>
2016-11-07 15:58 [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h> Masahiro Yamada
@ 2016-11-07 16:14 ` Russell King - ARM Linux
2016-11-15 15:50 ` Russell King - ARM Linux
0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-11-07 16:14 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-arm-kernel, linux-kernel
On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote:
> Nothing in this header file depends on <linux/types.h>.
> Rather, <linux/errno.h> should be included for -ENODEV.
So how do we end up with a definition for u32?
I think you need both these include files.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>
2016-11-07 16:14 ` Russell King - ARM Linux
@ 2016-11-15 15:50 ` Russell King - ARM Linux
0 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2016-11-15 15:50 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kernel, linux-arm-kernel
On Mon, Nov 07, 2016 at 04:14:48PM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote:
> > Nothing in this header file depends on <linux/types.h>.
> > Rather, <linux/errno.h> should be included for -ENODEV.
>
> So how do we end up with a definition for u32?
>
> I think you need both these include files.
I've noticed you haven't responded to the above.
I've discarded the patch you've placed in the patch system in the hope
of a replacement with this comment addressed.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>
@ 2016-11-03 22:57 Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2016-11-03 22:57 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Masahiro Yamada, Russell King, linux-kernel
Nothing in this header file depends on <linux/types.h>.
Rather, <linux/errno.h> should be included for -ENODEV.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/include/asm/hardware/cache-uniphier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/hardware/cache-uniphier.h b/arch/arm/include/asm/hardware/cache-uniphier.h
index eaa60da..0ef42ae 100644
--- a/arch/arm/include/asm/hardware/cache-uniphier.h
+++ b/arch/arm/include/asm/hardware/cache-uniphier.h
@@ -16,7 +16,7 @@
#ifndef __CACHE_UNIPHIER_H
#define __CACHE_UNIPHIER_H
-#include <linux/types.h>
+#include <linux/errno.h>
#ifdef CONFIG_CACHE_UNIPHIER
int uniphier_cache_init(void);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-15 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-07 15:58 [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h> Masahiro Yamada
2016-11-07 16:14 ` Russell King - ARM Linux
2016-11-15 15:50 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2016-11-03 22:57 Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).