linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] btrfs: Remove some dead code
@ 2016-11-04  7:02 Christophe JAILLET
  2016-11-07 16:19 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2016-11-04  7:02 UTC (permalink / raw)
  To: clm, jbacik, dsterba
  Cc: linux-btrfs, linux-kernel, kernel-janitors, Christophe JAILLET

'btrfs_iget()' can not return NULL, so this test can be removed.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
V1 --> v2: fix the patch description
---
 fs/btrfs/free-space-cache.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index e4b48f377d3a..afd8b0c10acd 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -75,8 +75,6 @@ static struct inode *__lookup_free_space_inode(struct btrfs_root *root,
 	btrfs_release_path(path);
 
 	inode = btrfs_iget(root->fs_info->sb, &location, root, NULL);
-	if (!inode)
-		return ERR_PTR(-ENOENT);
 	if (IS_ERR(inode))
 		return inode;
 	if (is_bad_inode(inode)) {
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] btrfs: Remove some dead code
  2016-11-04  7:02 [PATCH V2] btrfs: Remove some dead code Christophe JAILLET
@ 2016-11-07 16:19 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2016-11-07 16:19 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: clm, jbacik, dsterba, linux-btrfs, linux-kernel, kernel-janitors

On Fri, Nov 04, 2016 at 08:02:35AM +0100, Christophe JAILLET wrote:
> 'btrfs_iget()' can not return NULL, so this test can be removed.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Patch replaced, I've edited the subject to be a bit more specific.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-07 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04  7:02 [PATCH V2] btrfs: Remove some dead code Christophe JAILLET
2016-11-07 16:19 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).