[PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

[PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

[Shiva Kerdel]

Follow the kernel type preferrences of using 's16' over 'int16_t'.

Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
---
 drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index e915574..c7cad87 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -42,8 +42,8 @@ struct msi_domain_info;
  */
 struct fsl_mc_resource_pool {
 	enum fsl_mc_pool_type type;
-	int16_t max_count;
-	int16_t free_count;
+	s16 max_count;
+	s16 free_count;
 	struct mutex mutex;	/* serializes access to free_list */
 	struct list_head free_list;
 	struct fsl_mc_bus *mc_bus;
-- 
2.10.2

[PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

[Shiva Kerdel]

Follow the kernel type preferrences of using 's32' over 'int32_t'.

Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
---
 drivers/staging/fsl-mc/include/mc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
index a781a36..1c46c0c 100644
--- a/drivers/staging/fsl-mc/include/mc.h
+++ b/drivers/staging/fsl-mc/include/mc.h
@@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
  */
 struct fsl_mc_resource {
 	enum fsl_mc_pool_type type;
-	int32_t id;
+	s32 id;
 	void *data;
 	struct fsl_mc_resource_pool *parent_pool;
 	struct list_head node;
-- 
2.10.2

RE: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

[Stuart Yoder]

> -----Original Message-----
> From: Shiva Kerdel [mailto:shiva@exdev.nl]
> Sent: Tuesday, November 08, 2016 9:42 AM
> To: Stuart Yoder <stuart.yoder@nxp.com>
> Cc: gregkh@linuxfoundation.org; German.Rivera@freescale.com; German Rivera <german.rivera@nxp.com>;
> treding@nvidia.com; itai.katz@nxp.com; Nipun Gupta <nipun.gupta@nxp.com>; linux-kernel@vger.kernel.org;
> devel@driverdev.osuosl.org; Shiva Kerdel <shiva@exdev.nl>
> Subject: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'
> 
> Follow the kernel type preferrences of using 's16' over 'int16_t'.
> 
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> ---
>  drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
> index e915574..c7cad87 100644
> --- a/drivers/staging/fsl-mc/include/mc-bus.h
> +++ b/drivers/staging/fsl-mc/include/mc-bus.h
> @@ -42,8 +42,8 @@ struct msi_domain_info;
>   */
>  struct fsl_mc_resource_pool {
>  	enum fsl_mc_pool_type type;
> -	int16_t max_count;
> -	int16_t free_count;
> +	s16 max_count;
> +	s16 free_count;
>  	struct mutex mutex;	/* serializes access to free_list */
>  	struct list_head free_list;
>  	struct fsl_mc_bus *mc_bus;

Acked-by: Stuart Yoder <stuart.yoder@nxp.com>

RE: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

[Stuart Yoder]

> -----Original Message-----
> From: Shiva Kerdel [mailto:shiva@exdev.nl]
> Sent: Tuesday, November 08, 2016 9:42 AM
> To: Stuart Yoder <stuart.yoder@nxp.com>
> Cc: gregkh@linuxfoundation.org; German.Rivera@freescale.com; German Rivera <german.rivera@nxp.com>;
> treding@nvidia.com; itai.katz@nxp.com; Nipun Gupta <nipun.gupta@nxp.com>; linux-kernel@vger.kernel.org;
> devel@driverdev.osuosl.org; Shiva Kerdel <shiva@exdev.nl>
> Subject: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'
> 
> Follow the kernel type preferrences of using 's32' over 'int32_t'.
> 
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> ---
>  drivers/staging/fsl-mc/include/mc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h
> index a781a36..1c46c0c 100644
> --- a/drivers/staging/fsl-mc/include/mc.h
> +++ b/drivers/staging/fsl-mc/include/mc.h
> @@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
>   */
>  struct fsl_mc_resource {
>  	enum fsl_mc_pool_type type;
> -	int32_t id;
> +	s32 id;
>  	void *data;
>  	struct fsl_mc_resource_pool *parent_pool;
>  	struct list_head node;

Acked-by: Stuart Yoder <stuart.yoder@nxp.com>

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

[Greg KH]

On Tue, Nov 08, 2016 at 04:42:13PM +0100, Shiva Kerdel wrote:
> Follow the kernel type preferrences of using 's16' over 'int16_t'.
> 
> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
> ---
>  drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

What is different from your v1 patch?

I'm confused now, I have two different series from you, one 6 patches
long, and one 2 patches long, claiming to do the same thing.

I've dropped them both from my patch review queue and please, resend
what you really want me to apply :)

thanks,

greg k-h

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

[Shiva Kerdel]

Sorry for this misunderstanding,

Since received a response from Stuart on my previous patch telling me I 
was probably working on a out-of-date codebase,
I started to look where I did go wrong.

After some research I found out that I was always one step behind 
because I was developing on the actual Linux kernel branch instead
of using the Staging-next as my codebase.

He wrote me to sent the patches that still apply over again with a new 
version tag so that's why this patch only contains 2 of them.

I am still new at contributing to the Linux kernel and some things were 
not really clear to me at the beginning.
I hope that you could still use these patches and I am trying to avoid 
misunderstandings like these.

Do I still need to resend them and is there anything left for me to do 
with these?

Best regards,

Shiva Kerdel

On 11/10/16 13:24, Greg KH wrote:
> On Tue, Nov 08, 2016 at 04:42:13PM +0100, Shiva Kerdel wrote:
>> Follow the kernel type preferrences of using 's16' over 'int16_t'.
>>
>> Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
>> ---
>>   drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
> What is different from your v1 patch?
>
> I'm confused now, I have two different series from you, one 6 patches
> long, and one 2 patches long, claiming to do the same thing.
>
> I've dropped them both from my patch review queue and please, resend
> what you really want me to apply :)
>
> thanks,
>
> greg k-h

Re: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

[Greg KH]

On Thu, Nov 10, 2016 at 01:33:10PM +0100, Shiva Kerdel wrote:
> Sorry for this misunderstanding,
> 
> Since received a response from Stuart on my previous patch telling me I was
> probably working on a out-of-date codebase,
> I started to look where I did go wrong.
> 
> After some research I found out that I was always one step behind because I
> was developing on the actual Linux kernel branch instead
> of using the Staging-next as my codebase.
> 
> He wrote me to sent the patches that still apply over again with a new
> version tag so that's why this patch only contains 2 of them.
> 
> I am still new at contributing to the Linux kernel and some things were not
> really clear to me at the beginning.
> I hope that you could still use these patches and I am trying to avoid
> misunderstandings like these.
> 
> Do I still need to resend them and is there anything left for me to do with
> these?

Please resend, with the acks added, as these are gone from my patch
queue.

thanks,

greg k-h