[RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Peter Rosin]

While at it, clean up some other things as well.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 .../devicetree/bindings/regulator/pwm-regulator.txt          | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
index 3aeba9f86ed8..6d98fbaeb506 100644
--- a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
@@ -55,11 +55,11 @@ Optional properties:
 - enable-gpios:		GPIO to use to enable/disable the regulator
 
 Any property defined as part of the core regulator binding can also be used.
-(See: ../regulator/regulator.txt)
+(See: regulator.txt)
 
 Continuous Voltage With Enable GPIO Example:
-	pwm_regulator {
-		compatible = "pwm-regulator;
+	pwm-regulator {
+		compatible = "pwm-regulator";
 		pwms = <&pwm1 0 8448 0>;
 		enable-gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>;
 		regulator-min-microvolt = <1016000>;
@@ -71,12 +71,12 @@ Continuous Voltage With Enable GPIO Example:
 		 * Inverted PWM logic, and the duty cycle range is limited
 		 * to 30%-70%.
 		 */
-		pwm-dutycycle-range <700 300>; /* */
+		pwm-dutycycle-range <700 300>;
 	};
 
 Voltage Table Example:
-	pwm_regulator {
-		compatible = "pwm-regulator;
+	pwm-regulator {
+		compatible = "pwm-regulator";
 		pwms = <&pwm1 0 8448 0>;
 		regulator-min-microvolt = <1016000>;
 		regulator-max-microvolt = <1114000>;
-- 
2.1.4

Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

On Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:
> While at it, clean up some other things as well.

This isn't a useful changelog, it's just saying that there's some
random changes for no reason.  Please make proper patches with
changelogs that explain them.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Peter Rosin]

On 2016-11-10 17:18, Mark Brown wrote:
> On Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:
>> While at it, clean up some other things as well.
> 
> This isn't a useful changelog, it's just saying that there's some
> random changes for no reason.  Please make proper patches with
> changelogs that explain them.

It's a very uninteresting patch, I guess I made a changelog to match.
But I can't help myself from asking a few qustions...

Patch*es* and changelog*s*?

Oh, you want me to split into a series of several patches? One for the
quotes, one for the "../regultor/" removal, one for the empty
comment removal and one for the s/pwm_reglator/pwm-regulator/ thing?

Be careful what you ask for, you might get it...

Or are you saying that patches that I make have poor descriptions
in general?

Anyway, I'm done with that file, if you want crappy docs, by all
means throw the patch away.

Cheers,
Peter

Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

On Thu, Nov 10, 2016 at 06:05:59PM +0100, Peter Rosin wrote:
> On 2016-11-10 17:18, Mark Brown wrote:
> > On Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:

> >> While at it, clean up some other things as well.

> > This isn't a useful changelog, it's just saying that there's some
> > random changes for no reason.  Please make proper patches with
> > changelogs that explain them.

> It's a very uninteresting patch, I guess I made a changelog to match.
> But I can't help myself from asking a few qustions...

> Patch*es* and changelog*s*?

> Oh, you want me to split into a series of several patches? One for the
> quotes, one for the "../regultor/" removal, one for the empty
> comment removal and one for the s/pwm_reglator/pwm-regulator/ thing?

> Be careful what you ask for, you might get it...

The above is not a problem for me, indeed it's actually good as it makes
it *much* quicker and simpler for me to read the changes and figure out
if they all make sense and do what was intended.  The less the changelog
says about what the change is supposed to do and the more different
things the change does the more effort is required to work out if it's
sensible and the more chance there is of one of the changes blocking the
other ones.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Rob Herring]

qOn Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:
> While at it, clean up some other things as well.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../devicetree/bindings/regulator/pwm-regulator.txt          | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

As this is just DT docs, I've applied.

Rob

Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

On Mon, Nov 14, 2016 at 07:47:02PM -0600, Rob Herring wrote:
> qOn Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:
> > While at it, clean up some other things as well.

> As this is just DT docs, I've applied.

That's now going to conflict with some updates I've got...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [RESEND PATCH] regulator: pwm: fix syntax errors in the examples

[Rob Herring]

On Tue, Nov 15, 2016 at 8:34 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Nov 14, 2016 at 07:47:02PM -0600, Rob Herring wrote:
>> qOn Thu, Nov 10, 2016 at 11:25:27AM +0100, Peter Rosin wrote:
>> > While at it, clean up some other things as well.
>
>> As this is just DT docs, I've applied.
>
> That's now going to conflict with some updates I've got...

Okay, I've dropped it. You can add my ack.

Rob