* [PATCH] dmaengine: fsl_raid: Fix module autoload
@ 2016-10-19 20:32 Javier Martinez Canillas
2016-11-14 3:05 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-10-19 20:32 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Dan Williams, dmaengine, Vinod Koul
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/dma/fsl_raid.ko | grep alias
$
After this patch:
$ modinfo drivers/dma/fsl_raid.ko | grep alias
alias: of:N*T*Cfsl,raideng-v1.0C*
alias: of:N*T*Cfsl,raideng-v1.0
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/dma/fsl_raid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
index db2f9e1653a2..90d29f90acfb 100644
--- a/drivers/dma/fsl_raid.c
+++ b/drivers/dma/fsl_raid.c
@@ -881,6 +881,7 @@ static struct of_device_id fsl_re_ids[] = {
{ .compatible = "fsl,raideng-v1.0", },
{}
};
+MODULE_DEVICE_TABLE(of, fsl_re_ids);
static struct platform_driver fsl_re_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: fsl_raid: Fix module autoload
2016-10-19 20:32 [PATCH] dmaengine: fsl_raid: Fix module autoload Javier Martinez Canillas
@ 2016-11-14 3:05 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-11-14 3:05 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Dan Williams, dmaengine
On Wed, Oct 19, 2016 at 05:32:33PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/dma/fsl_raid.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/dma/fsl_raid.ko | grep alias
> alias: of:N*T*Cfsl,raideng-v1.0C*
> alias: of:N*T*Cfsl,raideng-v1.0
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-14 2:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-19 20:32 [PATCH] dmaengine: fsl_raid: Fix module autoload Javier Martinez Canillas
2016-11-14 3:05 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).