From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH] x86/topology: Document cpu_llc_id
Date: Mon, 14 Nov 2016 07:29:01 +0100 [thread overview]
Message-ID: <20161114062901.il4ucv5muw4ksfsv@pd.tnic> (raw)
In-Reply-To: <20160907103641.GO10138@twins.programming.kicks-ass.net>
On Wed, Sep 07, 2016 at 12:36:41PM +0200, Peter Zijlstra wrote:
> On Wed, Sep 07, 2016 at 11:22:19AM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > It means different things on Intel and AMD so write it down so that
> > there's no confusion.
> >
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > Documentation/x86/topology.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
> > index 06afac252f5b..7a5485730476 100644
> > --- a/Documentation/x86/topology.txt
> > +++ b/Documentation/x86/topology.txt
> > @@ -63,6 +63,12 @@ The topology of a system is described in the units of:
> > The maximum possible number of packages in the system. Helpful for per
> > package facilities to preallocate per package information.
> >
> > + - cpu_llc_id:
> > +
> > + A per-CPU variable containing:
> > + - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
> > + Cache
> > + - On AMD, the Node ID containing the Last Level Cache.
>
> And there are no AMD parts where there are multiple LLCs on a Node? Like
> where there isn't an L3 and the L2 is only per cluster?
Yes there are (now), see:
http://git.kernel.org/tip/b0b6e86846093c5f8820386bc01515f857dd8faa
But those LLC ID numbers are still increasing IDs of either nodes or
core complexes in Zen's case. So I think the text should say:
"- On AMD, the Node ID or Core Complex ID containing the Last Level Cache. In
general, numbers identifying an LLC uniquely on the system."
How's that?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2016-11-14 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 9:22 [PATCH] x86/topology: Document cpu_llc_id Borislav Petkov
2016-09-07 10:36 ` Peter Zijlstra
2016-11-14 6:29 ` Borislav Petkov [this message]
2016-11-17 9:45 ` [PATCH -v1.1] " Borislav Petkov
2016-11-17 12:57 ` Yazen Ghannam
2016-11-17 14:16 ` Borislav Petkov
2016-12-19 11:34 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2016-12-20 9:34 ` tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114062901.il4ucv5muw4ksfsv@pd.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).