[PATCH] [STYLE]staging:braille:braille_console.c [1/2]

[PATCH] [STYLE]staging:braille:braille_console.c [1/2]

[Walt Feasel]

Made suggested modifications from checkpatch in reference
to ERROR: Use 4 digit octal (0777) not decimal permissions

Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
 drivers/accessibility/braille/braille_console.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
index dc34a5b..7ac3d5f 100644
--- a/drivers/accessibility/braille/braille_console.c
+++ b/drivers/accessibility/braille/braille_console.c
@@ -45,7 +45,7 @@ MODULE_LICENSE("GPL");
 
 /* Emit various sounds */
 static bool sound;
-module_param(sound, bool, 0);
+module_param(sound, bool, 0000);
 MODULE_PARM_DESC(sound, "emit sounds");
 
 static void beep(unsigned int freq)
-- 
2.1.4

Re: [PATCH] [STYLE]staging:braille:braille_console.c [1/2]

[Greg KH]

On Thu, Nov 10, 2016 at 08:12:07PM -0500, Walt Feasel wrote:
> Made suggested modifications from checkpatch in reference
> to ERROR: Use 4 digit octal (0777) not decimal permissions
> 
> Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
> ---
>  drivers/accessibility/braille/braille_console.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

{sigh}

Ok, I count over a hundred different patches from you in my inbox for
review.  That's great, but you need to redo them so that I can review
them.

First off, your Subject: lines are a bit odd.  You don't need the
"[STYLE]" portion, and you move around the [1/2] from the front to the
end.  Also, you aren't using git to number them, so they go from 9/12 to
10/12, which does not sort (it should be 09/12).

So please, use git to create the patch series.

Look at other patches sent to the lists for how to get good subjects,
don't use the same subject for multiple patches, that is an easy grounds
for rejection, and please put space characters after ':'.

Also say what you are doing in the subject, you don't do that here at
all.

So, for example, this Subject should be:
  [PATCH] staging: speakup: braille_console.c: use octal mode values

Read the file, Documentation/SubmittingPatches for a good description of
how to make a good subject.


Second, your patches are not threaded at all.  If you use 'git
send-email' they will all be linked up properly, making it much easier
for me to apply them, and for others to just delete them when they don't
care about the patch series.

So use 'git send-email' please.

And when using git send-email, send out patches in batches for a
specific driver, don't send out multiple series for the same driver, as
then I don't know which to accept or not.

Thirdly, please properly cc: the maintainers and developers of the
drivers you are modifying.  Use 'scripts/get_maintainers.pl' to do this.
You seem to do it in some places, but not all, so it's hard to know what
is going on there.

And lastly, slow down a bit.  Try all of this out on a single patch
series first.  Once you get them accepted, then keep going, and work on
more.  I don't want to see you waste energy on things that don't get
accepted (like all of these patches).

Does this help?

Right now I'm going to drop all of the patches you sent me, so please,
work on the above things and start to slowly resend them, in the proper
format, so that I can accept them and merge them to the kernel tree,
which is what we both want to see happen.

thanks,

greg k-h