[PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Johan Hovold]

Make sure to drop the reference taken by bus_find_device_by_name()
before returning from mfd_clone_cell().

Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/mfd/mfd-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 3ac486a597f3..c57e407020f1 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -399,6 +399,8 @@ int mfd_clone_cell(const char *cell, const char **clones, size_t n_clones)
 					clones[i]);
 	}
 
+	put_device(dev);
+
 	return 0;
 }
 EXPORT_SYMBOL(mfd_clone_cell);
-- 
2.7.3

Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Lee Jones]

On Tue, 01 Nov 2016, Johan Hovold wrote:

> Make sure to drop the reference taken by bus_find_device_by_name()
> before returning from mfd_clone_cell().
> 
> Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/mfd/mfd-core.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 3ac486a597f3..c57e407020f1 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -399,6 +399,8 @@ int mfd_clone_cell(const char *cell, const char **clones, size_t n_clones)
>  					clones[i]);
>  	}
>  
> +	put_device(dev);
> +
>  	return 0;
>  }
>  EXPORT_SYMBOL(mfd_clone_cell);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Johan Hovold]

On Mon, Nov 14, 2016 at 06:25:01PM +0000, Lee Jones wrote:
> On Tue, 01 Nov 2016, Johan Hovold wrote:
> 
> > Make sure to drop the reference taken by bus_find_device_by_name()
> > before returning from mfd_clone_cell().
> > 
> > Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/mfd/mfd-core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Applied, thanks.

I do not see this one in linux-next (or your tree). Did you forget to
push?

Thanks,
Johan

Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Lee Jones]

On Wed, 16 Nov 2016, Johan Hovold wrote:

> On Mon, Nov 14, 2016 at 06:25:01PM +0000, Lee Jones wrote:
> > On Tue, 01 Nov 2016, Johan Hovold wrote:
> > 
> > > Make sure to drop the reference taken by bus_find_device_by_name()
> > > before returning from mfd_clone_cell().
> > > 
> > > Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> > >  drivers/mfd/mfd-core.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > Applied, thanks.
> 
> I do not see this one in linux-next (or your tree). Did you forget to
> push?

Since I tend to flit between maintaining and real-work, I tend to bulk
push once I have a bunch of fixes/updates.  Your fix should appear in
-next tomorrow.  The plan is to have it in upstream by next week.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Johan Hovold]

On Wed, Nov 16, 2016 at 09:59:44AM +0000, Lee Jones wrote:
> On Wed, 16 Nov 2016, Johan Hovold wrote:
> 
> > On Mon, Nov 14, 2016 at 06:25:01PM +0000, Lee Jones wrote:
> > > On Tue, 01 Nov 2016, Johan Hovold wrote:
> > > 
> > > > Make sure to drop the reference taken by bus_find_device_by_name()
> > > > before returning from mfd_clone_cell().
> > > > 
> > > > Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
> > > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > > ---
> > > >  drivers/mfd/mfd-core.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > 
> > > Applied, thanks.
> > 
> > I do not see this one in linux-next (or your tree). Did you forget to
> > push?
> 
> Since I tend to flit between maintaining and real-work, I tend to bulk
> push once I have a bunch of fixes/updates.  Your fix should appear in
> -next tomorrow.  The plan is to have it in upstream by next week.

Sounds good, thanks for the explanation.

Johan

Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

[Lee Jones]

On Wed, 16 Nov 2016, Johan Hovold wrote:

> On Wed, Nov 16, 2016 at 09:59:44AM +0000, Lee Jones wrote:
> > On Wed, 16 Nov 2016, Johan Hovold wrote:
> > 
> > > On Mon, Nov 14, 2016 at 06:25:01PM +0000, Lee Jones wrote:
> > > > On Tue, 01 Nov 2016, Johan Hovold wrote:
> > > > 
> > > > > Make sure to drop the reference taken by bus_find_device_by_name()
> > > > > before returning from mfd_clone_cell().
> > > > > 
> > > > > Fixes: a9bbba996302 ("mfd: add platform_device sharing support for mfd")
> > > > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > > > ---
> > > > >  drivers/mfd/mfd-core.c | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > Applied, thanks.
> > > 
> > > I do not see this one in linux-next (or your tree). Did you forget to
> > > push?
> > 
> > Since I tend to flit between maintaining and real-work, I tend to bulk
> > push once I have a bunch of fixes/updates.  Your fix should appear in
> > -next tomorrow.  The plan is to have it in upstream by next week.
> 
> Sounds good, thanks for the explanation.

FYI, I submitted your patch to Linus today.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog