[PATCH 0/3] arm64: Hikey: enable CPUFreq and thermal drivers

[PATCH 0/3] arm64: Hikey: enable CPUFreq and thermal drivers

[Leo Yan]

Currently most power management code of 96boards Hikey have been merged
into mainline kernel, but some of them have not been built by default;
So this patch series is to build all these modules properly.

The software layer is as below:

                        set constraint
    cpufreq-dt driver  <--------------  thermal/cpu_cooling driver
           |                                       |
	   V                                       V
  hi6220 stub clock driver                hisi thermal driver

So first two patches are two enable fundamental modules for hi6220 stub
clock driver and hisilicon thermal driver. Based on these two drivers,
we also need enable common drivers for cpufreq-dt.c and cpu_cooling.c;
these two drivers are commonly used by other platforms, so enable these
two common drivers in arm64's defconfig. arm32's defconfig has enabled
these two configurations yet.

Leo Yan (3):
  clk: Hi6220: enable stub clock driver for ARCH_HISI
  thermal: hisilicon: fix for dependency
  arm64: defconfig: enable two common modules for power management

 arch/arm64/configs/defconfig  | 2 ++
 drivers/clk/hisilicon/Kconfig | 1 +
 drivers/thermal/Kconfig       | 4 +++-
 3 files changed, 6 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/3] clk: Hi6220: enable stub clock driver for ARCH_HISI

[Leo Yan]

In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by
default, as result stub clock driver has not been registered and
CPUFreq driver cannot work.

This patch is to enable stub clock driver in config for ARCH_HISI.

Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 drivers/clk/hisilicon/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/hisilicon/Kconfig b/drivers/clk/hisilicon/Kconfig
index 3f537a0..9e0a95e 100644
--- a/drivers/clk/hisilicon/Kconfig
+++ b/drivers/clk/hisilicon/Kconfig
@@ -23,5 +23,6 @@ config RESET_HISI
 config STUB_CLK_HI6220
 	bool "Hi6220 Stub Clock Driver"
 	depends on COMMON_CLK_HI6220 && MAILBOX
+	default ARCH_HISI
 	help
 	  Build the Hisilicon Hi6220 stub clock driver.
-- 
1.9.1

Re: [PATCH 1/3] clk: Hi6220: enable stub clock driver for ARCH_HISI

[Stephen Boyd]

On 08/31, Leo Yan wrote:
> In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by
> default, as result stub clock driver has not been registered and
> CPUFreq driver cannot work.
> 
> This patch is to enable stub clock driver in config for ARCH_HISI.
> 
> Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 1/3] clk: Hi6220: enable stub clock driver for ARCH_HISI

[Leo Yan]

Hi Stephen,

On Wed, Aug 31, 2016 at 03:40:49PM -0700, Stephen Boyd wrote:
> On 08/31, Leo Yan wrote:
> > In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by
> > default, as result stub clock driver has not been registered and
> > CPUFreq driver cannot work.
> > 
> > This patch is to enable stub clock driver in config for ARCH_HISI.
> > 
> > Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > ---
> 
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>

We found this patch is missed mainline kernel. So could you help pick
it? Or do you need me resend this patch?

Thanks,
Leo Yan

Re: [PATCH 1/3] clk: Hi6220: enable stub clock driver for ARCH_HISI

[Stephen Boyd]

On 11/12, Leo Yan wrote:
> Hi Stephen,
> 
> On Wed, Aug 31, 2016 at 03:40:49PM -0700, Stephen Boyd wrote:
> > On 08/31, Leo Yan wrote:
> > > In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by
> > > default, as result stub clock driver has not been registered and
> > > CPUFreq driver cannot work.
> > > 
> > > This patch is to enable stub clock driver in config for ARCH_HISI.
> > > 
> > > Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > > ---
> > 
> > Acked-by: Stephen Boyd <sboyd@codeaurora.org>
> 
> We found this patch is missed mainline kernel. So could you help pick
> it? Or do you need me resend this patch?
> 

Sure I can fish it out and apply it.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 1/3] clk: Hi6220: enable stub clock driver for ARCH_HISI

[Stephen Boyd]

On 08/31, Leo Yan wrote:
> In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by
> default, as result stub clock driver has not been registered and
> CPUFreq driver cannot work.
> 
> This patch is to enable stub clock driver in config for ARCH_HISI.
> 
> Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 1/3] clk: Hi6220: enable stub clock driver for ARCH_HISI

[Leo Yan]

On Mon, Nov 14, 2016 at 06:41:00PM -0800, Stephen Boyd wrote:
> On 08/31, Leo Yan wrote:
> > In current kernel config 'CONFIG_STUB_CLK_HI6220' is disabled by
> > default, as result stub clock driver has not been registered and
> > CPUFreq driver cannot work.
> > 
> > This patch is to enable stub clock driver in config for ARCH_HISI.
> > 
> > Reported-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > ---
> 
> Applied to clk-next

Thanks :)

> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

[PATCH 2/3] thermal: hisilicon: fix for dependency

[Leo Yan]

The thermal driver is standalone driver which is used to enable
thermal sensors, so it can be used with any cooling device and
should not bind with CPU cooling device driver.

This original patch is suggested by Amit Kucheria; so it's to
polish the dependency in Kconfig, and remove the dependency with
CPU_THERMAL.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 drivers/thermal/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 2d702ca..91ebab3 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -177,8 +177,10 @@ config THERMAL_EMULATION
 
 config HISI_THERMAL
 	tristate "Hisilicon thermal driver"
-	depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
+	depends on ARCH_HISI || COMPILE_TEST
 	depends on HAS_IOMEM
+	depends on OF
+	default y
 	help
 	  Enable this to plug hisilicon's thermal sensor driver into the Linux
 	  thermal framework. cpufreq is used as the cooling device to throttle
-- 
1.9.1

Re: [PATCH 2/3] thermal: hisilicon: fix for dependency

[Leo Yan]

Hi Rui, Eduardo,

On Wed, Aug 31, 2016 at 04:50:16PM +0800, Leo Yan wrote:
> The thermal driver is standalone driver which is used to enable
> thermal sensors, so it can be used with any cooling device and
> should not bind with CPU cooling device driver.
> 
> This original patch is suggested by Amit Kucheria; so it's to
> polish the dependency in Kconfig, and remove the dependency with
> CPU_THERMAL.

Could you help review this patch? Or need me resend this patch? Sorry
I have not tracked this patches well before, this is one missed
patch for 96board Hikey.

Thanks,
Leo Yan

> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
>  drivers/thermal/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 2d702ca..91ebab3 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -177,8 +177,10 @@ config THERMAL_EMULATION
>  
>  config HISI_THERMAL
>  	tristate "Hisilicon thermal driver"
> -	depends on (ARCH_HISI && CPU_THERMAL && OF) || COMPILE_TEST
> +	depends on ARCH_HISI || COMPILE_TEST
>  	depends on HAS_IOMEM
> +	depends on OF
> +	default y
>  	help
>  	  Enable this to plug hisilicon's thermal sensor driver into the Linux
>  	  thermal framework. cpufreq is used as the cooling device to throttle
> -- 
> 1.9.1
> 

Re: [PATCH 2/3] thermal: hisilicon: fix for dependency

[Zhang Rui]

On Sat, 2016-11-12 at 20:05 +0800, Leo Yan wrote:
> Hi Rui, Eduardo,
> 
> On Wed, Aug 31, 2016 at 04:50:16PM +0800, Leo Yan wrote:
> > 
> > The thermal driver is standalone driver which is used to enable
> > thermal sensors, so it can be used with any cooling device and
> > should not bind with CPU cooling device driver.
> > 
> > This original patch is suggested by Amit Kucheria; so it's to
> > polish the dependency in Kconfig, and remove the dependency with
> > CPU_THERMAL.
> Could you help review this patch? Or need me resend this patch? Sorry
> I have not tracked this patches well before, this is one missed
> patch for 96board Hikey.
> 
as it still applies cleanly, the patch is queued for 4.10.

thanks,
rui
> Thanks,
> Leo Yan
> 
> > 
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > ---
> >  drivers/thermal/Kconfig | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 2d702ca..91ebab3 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -177,8 +177,10 @@ config THERMAL_EMULATION
> >  
> >  config HISI_THERMAL
> >  	tristate "Hisilicon thermal driver"
> > -	depends on (ARCH_HISI && CPU_THERMAL && OF) ||
> > COMPILE_TEST
> > +	depends on ARCH_HISI || COMPILE_TEST
> >  	depends on HAS_IOMEM
> > +	depends on OF
> > +	default y
> >  	help
> >  	  Enable this to plug hisilicon's thermal sensor driver
> > into the Linux
> >  	  thermal framework. cpufreq is used as the cooling device
> > to throttle

Re: [PATCH 2/3] thermal: hisilicon: fix for dependency

[Leo Yan]

On Tue, Nov 15, 2016 at 08:24:55PM +0800, Zhang Rui wrote:
> On Sat, 2016-11-12 at 20:05 +0800, Leo Yan wrote:
> > Hi Rui, Eduardo,
> > 
> > On Wed, Aug 31, 2016 at 04:50:16PM +0800, Leo Yan wrote:
> > > 
> > > The thermal driver is standalone driver which is used to enable
> > > thermal sensors, so it can be used with any cooling device and
> > > should not bind with CPU cooling device driver.
> > > 
> > > This original patch is suggested by Amit Kucheria; so it's to
> > > polish the dependency in Kconfig, and remove the dependency with
> > > CPU_THERMAL.
> > Could you help review this patch? Or need me resend this patch? Sorry
> > I have not tracked this patches well before, this is one missed
> > patch for 96board Hikey.
> > 
> as it still applies cleanly, the patch is queued for 4.10.

Thanks a lot.

> thanks,
> rui
> > Thanks,
> > Leo Yan
> > 
> > > 
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > > ---
> > >  drivers/thermal/Kconfig | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > > index 2d702ca..91ebab3 100644
> > > --- a/drivers/thermal/Kconfig
> > > +++ b/drivers/thermal/Kconfig
> > > @@ -177,8 +177,10 @@ config THERMAL_EMULATION
> > >  
> > >  config HISI_THERMAL
> > >  	tristate "Hisilicon thermal driver"
> > > -	depends on (ARCH_HISI && CPU_THERMAL && OF) ||
> > > COMPILE_TEST
> > > +	depends on ARCH_HISI || COMPILE_TEST
> > >  	depends on HAS_IOMEM
> > > +	depends on OF
> > > +	default y
> > >  	help
> > >  	  Enable this to plug hisilicon's thermal sensor driver
> > > into the Linux
> > >  	  thermal framework. cpufreq is used as the cooling device
> > > to throttle

[PATCH 3/3] arm64: defconfig: enable two common modules for power management

[Leo Yan]

Enable two common modules for power management, one is to enable
CPUFREQ_DT driver; this CPUFreq driver is used by many platforms by
passing OPP table from device tree.

Also enables CPU_THERMAL for CPU cooling device driver; so after we
enabled thermal framework and can bind thermal zone with CPU cooling
device driver.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index eadf485..9fd2681 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -82,6 +82,7 @@ CONFIG_COMPAT=y
 CONFIG_CPU_IDLE=y
 CONFIG_ARM_CPUIDLE=y
 CONFIG_CPU_FREQ=y
+CONFIG_CPUFREQ_DT=y
 CONFIG_ARM_BIG_LITTLE_CPUFREQ=y
 CONFIG_ARM_SCPI_CPUFREQ=y
 CONFIG_NET=y
@@ -252,6 +253,7 @@ CONFIG_SENSORS_INA2XX=m
 CONFIG_SENSORS_ARM_SCPI=y
 CONFIG_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
+CONFIG_CPU_THERMAL=y
 CONFIG_EXYNOS_THERMAL=y
 CONFIG_WATCHDOG=y
 CONFIG_RENESAS_WDT=y
-- 
1.9.1