From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna <nayna@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
Christophe Ricard <christophe.ricard@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: drop chip->is_open and chip->duration_adjusted
Date: Thu, 17 Nov 2016 09:36:41 -0800 [thread overview]
Message-ID: <20161117173641.uppc5vetyfuab7ts@intel.com> (raw)
In-Reply-To: <582D891D.9000801@linux.vnet.ibm.com>
On Thu, Nov 17, 2016 at 04:10:29PM +0530, Nayna wrote:
> On 11/15/2016 05:14 AM, Jarkko Sakkinen wrote:
> > - if (chip->flags & (TPM_CHIP_FLAG_TPM2 | TPM_CHIP_FLAG_VIRTUAL))
> > - return 0;
> > + if (test_bit(TPM_CHIP_FLAG_TPM2, &chip->flags) ||
> > + test_bit(TPM_CHIP_FLAG_VIRTUAL, &chip->flags))
> > + return;
>
> guess should be "return 0;"
Ouch. Good catch. Thank you.
/Jarkko
prev parent reply other threads:[~2016-11-17 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 23:44 [PATCH] tpm: drop chip->is_open and chip->duration_adjusted Jarkko Sakkinen
2016-11-15 4:30 ` Jason Gunthorpe
2016-11-15 5:11 ` Jarkko Sakkinen
2016-11-16 5:28 ` Jason Gunthorpe
2016-11-16 22:54 ` Jarkko Sakkinen
2016-11-17 10:40 ` [tpmdd-devel] " Nayna
2016-11-17 17:36 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117173641.uppc5vetyfuab7ts@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=christophe.ricard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).