* [PATCH] remoteproc: wcnss-pil: add QCOM_SMD dependency
@ 2016-11-18 16:15 Arnd Bergmann
2016-11-18 17:05 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-11-18 16:15 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Arnd Bergmann, Ohad Ben-Cohen, Vinod Koul, Peter Griffin,
Lee Jones, linux-remoteproc, linux-kernel
When qcom_smd is a loadable module and adsp-pil is built-in,
we get a link error:
drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_remove':
qcom_wcnss_iris.c:(.text.wcnss_smd_remove+0x10): undefined reference to `qcom_smd_unregister_edge'
drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_probe':
qcom_wcnss_iris.c:(.text.wcnss_smd_probe+0x12): undefined reference to `qcom_smd_register_edge'
This adds a Kconfig dependency to avoid this. We can still allow
build-testing with SMD disabled.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/remoteproc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index 5a0019ce7555..677b3fede83d 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -106,6 +106,7 @@ config QCOM_Q6V5_PIL
config QCOM_WCNSS_PIL
tristate "Qualcomm WCNSS Peripheral Image Loader"
depends on OF && ARCH_QCOM
+ depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD = n)
depends on QCOM_SMEM
depends on REMOTEPROC
select QCOM_MDT_LOADER
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remoteproc: wcnss-pil: add QCOM_SMD dependency
2016-11-18 16:15 [PATCH] remoteproc: wcnss-pil: add QCOM_SMD dependency Arnd Bergmann
@ 2016-11-18 17:05 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2016-11-18 17:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ohad Ben-Cohen, Vinod Koul, Peter Griffin, Lee Jones,
linux-remoteproc, linux-kernel
On Fri 18 Nov 08:15 PST 2016, Arnd Bergmann wrote:
> When qcom_smd is a loadable module and adsp-pil is built-in,
> we get a link error:
>
> drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_remove':
> qcom_wcnss_iris.c:(.text.wcnss_smd_remove+0x10): undefined reference to `qcom_smd_unregister_edge'
> drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_probe':
> qcom_wcnss_iris.c:(.text.wcnss_smd_probe+0x12): undefined reference to `qcom_smd_register_edge'
>
> This adds a Kconfig dependency to avoid this. We can still allow
> build-testing with SMD disabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied
Thanks,
Bjorn
> ---
> drivers/remoteproc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 5a0019ce7555..677b3fede83d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -106,6 +106,7 @@ config QCOM_Q6V5_PIL
> config QCOM_WCNSS_PIL
> tristate "Qualcomm WCNSS Peripheral Image Loader"
> depends on OF && ARCH_QCOM
> + depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD = n)
> depends on QCOM_SMEM
> depends on REMOTEPROC
> select QCOM_MDT_LOADER
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-18 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-18 16:15 [PATCH] remoteproc: wcnss-pil: add QCOM_SMD dependency Arnd Bergmann
2016-11-18 17:05 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).