[PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

[PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

[T.Zhou]

The code actually checks rt_queued not rt_nr_running
in pick_next_task_rt(), so change the corresponding
comment.

Signed-off-by: T.Zhou <t1zhou@163.com>
---
 kernel/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2516b8d..9b4a5c5 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
 
 	/*
 	 * We may dequeue prev's rt_rq in put_prev_task().
-	 * So, we update time before rt_nr_running check.
+	 * So, we update time before rt_queued check.
 	 */
 	if (prev->sched_class == &rt_sched_class)
 		update_curr_rt(rq);
-- 
2.7.3

Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

[Steven Rostedt]

Peter,

Can you pull this patch into your queue?

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve


On Fri, 18 Nov 2016 14:39:04 +0800
"T.Zhou" <t1zhou@163.com> wrote:

> The code actually checks rt_queued not rt_nr_running
> in pick_next_task_rt(), so change the corresponding
> comment.
> 
> Signed-off-by: T.Zhou <t1zhou@163.com>
> ---
>  kernel/sched/rt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 2516b8d..9b4a5c5 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
>  
>  	/*
>  	 * We may dequeue prev's rt_rq in put_prev_task().
> -	 * So, we update time before rt_nr_running check.
> +	 * So, we update time before rt_queued check.
>  	 */
>  	if (prev->sched_class == &rt_sched_class)
>  		update_curr_rt(rq);

Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

[Peter Zijlstra]

On Fri, Nov 18, 2016 at 09:53:07AM -0500, Steven Rostedt wrote:
> 
> Peter,
> 
> Can you pull this patch into your queue?

Not in my inbox..

Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

[Steven Rostedt]

On Fri, 18 Nov 2016 16:00:57 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Nov 18, 2016 at 09:53:07AM -0500, Steven Rostedt wrote:
> > 
> > Peter,
> > 
> > Can you pull this patch into your queue?  
> 
> Not in my inbox..

Can you get it from LKML? If not, I can bounce it to you.

-- Steve

Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

[T.Zhou]

Hi Peter,

On Fri, Nov 18, 2016 at 04:00:57PM +0100, Peter Zijlstra wrote:
> On Fri, Nov 18, 2016 at 09:53:07AM -0500, Steven Rostedt wrote:
> > 
> > Peter,
> > 
> > Can you pull this patch into your queue?
> 
> Not in my inbox..

This patch is so simple, so i do not want to interrupt you..
Will resend soon.

Thanks,
T.Zhou