From: Rabin Vincent <rabin@rab.in>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: mued dib <kreptor@gmail.com>,
davem@davemloft.net, jeffrey.t.kirsher@intel.com,
jiri@mellanox.com, saeedm@mellanox.com, idosch@mellanox.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
CARLOS.PALMINHA@synopsys.com, andreas.irestal@axis.com,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
lars.persson@axis.com
Subject: Re: Synopsys Ethernet QoS Driver
Date: Sat, 19 Nov 2016 14:56:54 +0100 [thread overview]
Message-ID: <20161119135654.GA14079@lnxartpec.se.axis.com> (raw)
In-Reply-To: <1dbb6047-2bbb-4d56-2a62-ab65a0254844@synopsys.com>
On Fri, Nov 18, 2016 at 02:20:27PM +0000, Joao Pinto wrote:
> For now we are interesting in improving the synopsys QoS driver under
> /nect/ethernet/synopsys. For now the driver structure consists of a single file
> called dwc_eth_qos.c, containing synopsys ethernet qos common ops and platform
> related stuff.
>
> Our strategy would be:
>
> a) Implement a platform glue driver (dwc_eth_qos_pltfm.c)
> b) Implement a pci glue driver (dwc_eth_qos_pci.c)
> c) Implement a "core driver" (dwc_eth_qos.c) that would only have Ethernet QoS
> related stuff to be reused by the platform / pci drivers
> d) Add a set of features to the "core driver" that we have available internally
Note that there are actually two drivers in mainline for this hardware:
drivers/net/ethernet/synopsis/
drivers/net/ethernet/stmicro/stmmac/
(See http://lists.openwall.net/netdev/2016/02/29/127)
The former only supports 4.x of the hardware.
The later supports 4.x and 3.x and already has a platform glue driver
with support for several platforms, a PCI glue driver, and a core driver
with several features not present in the former (for example: TX/RX
interrupt coalescing, EEE, PTP).
Have you evaluated both drivers? Why have you decided to work on the
former rather than the latter?
next prev parent reply other threads:[~2016-11-19 13:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADvZ6ErjyVR5ShWTk0QesWLYR1m3p8yAMkK8v9gm2kN5xTv8zw@mail.gmail.com>
2016-11-18 14:20 ` Synopsys Ethernet QoS Driver Joao Pinto
2016-11-19 13:56 ` Rabin Vincent [this message]
2016-11-21 5:29 ` Rayagond Kokatanur
2016-11-21 12:32 ` Joao Pinto
2016-11-21 12:52 ` Giuseppe CAVALLARO
2016-11-21 13:28 ` Lars Persson
2016-11-21 14:25 ` Giuseppe CAVALLARO
2016-11-21 15:06 ` Joao Pinto
2016-11-21 15:43 ` Lars Persson
2016-11-21 16:11 ` Joao Pinto
2016-11-22 14:16 ` Joao Pinto
2016-11-23 10:59 ` Giuseppe CAVALLARO
2016-11-23 11:10 ` Joao Pinto
2016-11-23 11:41 ` Lars Persson
2016-11-23 11:43 ` Joao Pinto
2016-11-25 8:55 ` Giuseppe CAVALLARO
2016-12-07 9:41 ` Pavel Machek
2016-11-21 13:48 ` Joao Pinto
2016-11-21 14:36 ` Giuseppe CAVALLARO
2016-11-21 15:00 ` Joao Pinto
2016-11-21 15:03 ` Giuseppe CAVALLARO
2016-11-21 15:14 ` Joao Pinto
[not found] ` <1806171479803900@web16j.yandex.ru>
2016-11-23 8:02 ` Giuseppe CAVALLARO
2016-12-07 20:15 ` Andy Shevchenko
2016-11-18 12:28 Joao Pinto
2016-11-18 12:31 ` Joao Pinto
2016-11-18 14:53 ` Florian Fainelli
2016-11-18 16:31 ` Joao Pinto
2016-11-18 16:35 ` Florian Fainelli
2016-11-18 16:40 ` Joao Pinto
2016-11-18 18:29 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119135654.GA14079@lnxartpec.se.axis.com \
--to=rabin@rab.in \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=andreas.irestal@axis.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=kreptor@gmail.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).