From: Lars Persson <lars.persson@axis.com>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: "Giuseppe CAVALLARO" <peppe.cavallaro@st.com>,
"Rayagond Kokatanur" <rayagond@vayavyalabs.com>,
"Rabin Vincent" <rabin@rab.in>, "mued dib" <kreptor@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
"jiri@mellanox.com" <jiri@mellanox.com>,
"saeedm@mellanox.com" <saeedm@mellanox.com>,
"idosch@mellanox.com" <idosch@mellanox.com>,
netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"CARLOS.PALMINHA@synopsys.com" <CARLOS.PALMINHA@synopsys.com>,
"Andreas Irestål" <andire@axis.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Synopsys Ethernet QoS Driver
Date: Mon, 21 Nov 2016 15:43:43 +0000 [thread overview]
Message-ID: <A001080B-2DC8-48D9-BD82-8276A9B3BE3D@axis.com> (raw)
In-Reply-To: <b126021d-e902-7a53-4d7a-e73ea89a66cf@synopsys.com>
> 21 nov. 2016 kl. 16:06 skrev Joao Pinto <Joao.Pinto@synopsys.com>:
>
>> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote:
>>> On 11/21/2016 2:28 PM, Lars Persson wrote:
>>>
>>>
>>>> 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO <peppe.cavallaro@st.com>:
>>>>
>>>> Hello Joao
>>>>
>>>>> On 11/21/2016 1:32 PM, Joao Pinto wrote:
>>>>> Hello,
>>>>>
>>>>>>> On 21-11-2016 05:29, Rayagond Kokatanur wrote:
>>>>>>>> On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent <rabin@rab.in> wrote:
>>>>>>>> On Fri, Nov 18, 2016 at 02:20:27PM +0000, Joao Pinto wrote:
>>>>>>>> For now we are interesting in improving the synopsys QoS driver under
>>>>>>>> /nect/ethernet/synopsys. For now the driver structure consists of a
>>>>>>>> single file
>>>>>>>> called dwc_eth_qos.c, containing synopsys ethernet qos common ops and
>>>>>>>> platform
>>>>>>>> related stuff.
>>>>>>>>
>>>>>>>> Our strategy would be:
>>>>>>>>
>>>>>>>> a) Implement a platform glue driver (dwc_eth_qos_pltfm.c)
>>>>>>>> b) Implement a pci glue driver (dwc_eth_qos_pci.c)
>>>>>>>> c) Implement a "core driver" (dwc_eth_qos.c) that would only have
>>>>>>>> Ethernet QoS
>>>>>>>> related stuff to be reused by the platform / pci drivers
>>>>>>>> d) Add a set of features to the "core driver" that we have available
>>>>>>>> internally
>>>>>>>
>>>>>>> Note that there are actually two drivers in mainline for this hardware:
>>>>>>>
>>>>>>> drivers/net/ethernet/synopsis/
>>>>>>> drivers/net/ethernet/stmicro/stmmac/
>>>>>>
>>>>>> Yes the later driver (drivers/net/ethernet/stmicro/stmmac/) supports
>>>>>> both 3.x and 4.x. It has glue layer for pci, platform, core etc,
>>>>>> please refer this driver once before you start.
>>>>>>
>>>>>> You can start adding missing feature of 4.x in stmmac driver.
>>>>>
>>>>> Thanks you all for all the info.
>>>>> Well, I think we are in a good position to organize the ethernet drivers
>>>>> concerning Synopsys IPs.
>>>>>
>>>>> First of all, in my opinion, it does not make sense to have a ethernet/synopsis
>>>>> (typo :)) when ethernet/stmicro is also for a synopsys IP. If we have another
>>>>> vendor using the same IP it should be able to reuse the commonn operations. But
>>>>> I would put that discussion for later :)
>>>>>
>>>>> For now I suggest that for we create ethernet/qos and create there a folder
>>>>> called dwc (designware controller) where all the synopsys qos IP specific code
>>>>> in order to be reused for example by ethernet/stmicro/stmmac/. We just have to
>>>>> figure out a clean interface for "client drivers" like stmmac to interact with
>>>>> the new qos driver.
>>>>>
>>>>> What do you think about this approach?
>>>>
>>>> The stmmac drivers run since many years on several platforms
>>>> (sh4, stm32, arm, x86, mips ...) and it supports an huge of amount of
>>>> configurations starting from 3.1x to 3.7x databooks.
>>>>
>>>> It also supports QoS hardware; for example, 4.00a, 4.10a and 4.20a
>>>> are fully working.
>>>>
>>>> Also the stmmac has platform, device-tree and pcie supports and
>>>> a lot of maintained glue-logic files.
>>>>
>>>> It is fully documented inside the kernel tree.
>>>>
>>>> I am happy to have new enhancements from other developers.
>>>> So, on my side, if you want to spend your time on improving it on your
>>>> platforms please feel free to do it!
>>>>
>>>> Concerning the stmicro/stmmac naming, these come from a really old
>>>> story and have no issue to adopt new folder/file names.
>>>>
>>>> I am also open to merge fixes and changes from ethernet/synopsis.
>>>> I want to point you on some benchmarks made by Alex some months ago
>>>> (IIRC) that showed an stmmac winner (due to the several optimizations
>>>> analyzed and reviewed in this mailing list).
>>>>
>>>> Peppe
>>>>
>>>
>>> Hello Joao and others,
>>>
>
> Hi Lars,
>
>>> As the maintainer of dwc_eth_qos.c I prefer also that we put efforts on the
>>> most mature driver, the stmmac.
>>>
>>> I hope that the code can migrate into an ethernet/synopsys folder to keep the
>>> convention of naming the folder after the vendor. This makes it easy for
>>> others to find the driver.
>>>
>>> The dwc_eth_qos.c will eventually be removed and its DT binding interface can
>>> then be implemented in the stmmac driver.
>
> So your ideia is to pick the ethernet/stmmac and rename it to ethernet/synopsys
> and try to improve the structure and add the missing QoS features to it?
Indeed this is what I prefer.
>
>>
>> Thanks Lars, I will be happy to support all you on this transition
>> and I agree on renaming all.
>>
>> peppe
>>
>>
>>> - Lars
>>>
>>>>>
>>>>>
>>>>>>
>>>>>>>
>>>>>>> (See http://lists.openwall.net/netdev/2016/02/29/127)
>>>>>>>
>>>>>>> The former only supports 4.x of the hardware.
>>>>>>>
>>>>>>> The later supports 4.x and 3.x and already has a platform glue driver
>>>>>>> with support for several platforms, a PCI glue driver, and a core driver
>>>>>>> with several features not present in the former (for example: TX/RX
>>>>>>> interrupt coalescing, EEE, PTP).
>>>>>>>
>>>>>>> Have you evaluated both drivers? Why have you decided to work on the
>>>>>>> former rather than the latter?
>>>>>>
>>>>>>
>>>>>
>>>>> Thanks.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2016-11-21 15:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADvZ6ErjyVR5ShWTk0QesWLYR1m3p8yAMkK8v9gm2kN5xTv8zw@mail.gmail.com>
2016-11-18 14:20 ` Synopsys Ethernet QoS Driver Joao Pinto
2016-11-19 13:56 ` Rabin Vincent
2016-11-21 5:29 ` Rayagond Kokatanur
2016-11-21 12:32 ` Joao Pinto
2016-11-21 12:52 ` Giuseppe CAVALLARO
2016-11-21 13:28 ` Lars Persson
2016-11-21 14:25 ` Giuseppe CAVALLARO
2016-11-21 15:06 ` Joao Pinto
2016-11-21 15:43 ` Lars Persson [this message]
2016-11-21 16:11 ` Joao Pinto
2016-11-22 14:16 ` Joao Pinto
2016-11-23 10:59 ` Giuseppe CAVALLARO
2016-11-23 11:10 ` Joao Pinto
2016-11-23 11:41 ` Lars Persson
2016-11-23 11:43 ` Joao Pinto
2016-11-25 8:55 ` Giuseppe CAVALLARO
2016-12-07 9:41 ` Pavel Machek
2016-11-21 13:48 ` Joao Pinto
2016-11-21 14:36 ` Giuseppe CAVALLARO
2016-11-21 15:00 ` Joao Pinto
2016-11-21 15:03 ` Giuseppe CAVALLARO
2016-11-21 15:14 ` Joao Pinto
[not found] ` <1806171479803900@web16j.yandex.ru>
2016-11-23 8:02 ` Giuseppe CAVALLARO
2016-12-07 20:15 ` Andy Shevchenko
2016-11-18 12:28 Joao Pinto
2016-11-18 12:31 ` Joao Pinto
2016-11-18 14:53 ` Florian Fainelli
2016-11-18 16:31 ` Joao Pinto
2016-11-18 16:35 ` Florian Fainelli
2016-11-18 16:40 ` Joao Pinto
2016-11-18 18:29 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A001080B-2DC8-48D9-BD82-8276A9B3BE3D@axis.com \
--to=lars.persson@axis.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=andire@axis.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=kreptor@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rabin@rab.in \
--cc=rayagond@vayavyalabs.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).