From: Greg KH <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Badhri Jagan Sridharan <badhri@google.com>,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv11 2/3] usb: USB Type-C connector class
Date: Mon, 21 Nov 2016 11:33:11 +0100 [thread overview]
Message-ID: <20161121103311.GA2233@kroah.com> (raw)
In-Reply-To: <20161117105036.133406-3-heikki.krogerus@linux.intel.com>
On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote:
> The purpose of USB Type-C connector class is to provide
> unified interface for the user space to get the status and
> basic information about USB Type-C connectors on a system,
> control over data role swapping, and when the port supports
> USB Power Delivery, also control over power role swapping
> and Alternate Modes.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
I'd like to get some acks or reviewed-by from others, but one thing
jumped out at me, which implies you did not run checkpatch.pl on the
patch:
644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -152,6 +152,8 @@ source "drivers/usb/phy/Kconfig"
>
> source "drivers/usb/gadget/Kconfig"
>
> +source "drivers/usb/typec/Kconfig"
> +
> config USB_LED_TRIG
> bool "USB LED Triggers"
> depends on LEDS_CLASS && LEDS_TRIGGERS
> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile
> index 7791af6..c7f4098 100644
> --- a/drivers/usb/Makefile
> +++ b/drivers/usb/Makefile
> @@ -62,3 +62,5 @@ obj-$(CONFIG_USB_GADGET) += gadget/
> obj-$(CONFIG_USB_COMMON) += common/
>
> obj-$(CONFIG_USBIP_CORE) += usbip/
> +
> +obj-$(CONFIG_TYPEC) += typec/
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> new file mode 100644
> index 0000000..b229fb9
> --- /dev/null
> +++ b/drivers/usb/typec/Kconfig
> @@ -0,0 +1,7 @@
> +
> +menu "USB PD and Type-C drivers"
What is "PD"? (yes, I know, but very few people do...) Spell it out.
> +
> +config TYPEC
> + tristate
Hah, that says NOTHING about what this code is at all.
Please fix.
thanks,
greg k-h
next prev parent reply other threads:[~2016-11-21 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 10:50 [PATCHv11 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-21 10:33 ` Greg KH [this message]
2016-11-21 13:27 ` Heikki Krogerus
2016-11-21 14:46 ` Greg KH
2016-11-22 7:58 ` Heikki Krogerus
2016-11-22 8:19 ` Greg KH
2016-11-21 10:35 ` Greg KH
2016-11-21 13:11 ` Heikki Krogerus
2016-11-21 14:23 ` Heikki Krogerus
2016-11-21 15:33 ` Guenter Roeck
2016-11-22 8:52 ` Heikki Krogerus
2016-11-21 14:45 ` Greg KH
2016-11-22 10:51 ` Heikki Krogerus
2016-11-22 13:37 ` Heikki Krogerus
2016-11-22 13:45 ` Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121103311.GA2233@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).