From: Greg KH <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Badhri Jagan Sridharan <badhri@google.com>,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv11 2/3] usb: USB Type-C connector class
Date: Tue, 22 Nov 2016 09:19:42 +0100 [thread overview]
Message-ID: <20161122081942.GA30186@kroah.com> (raw)
In-Reply-To: <20161122075813.GD18501@kuha.fi.intel.com>
On Tue, Nov 22, 2016 at 09:58:13AM +0200, Heikki Krogerus wrote:
> Hi Greg,
>
> On Mon, Nov 21, 2016 at 03:46:08PM +0100, Greg KH wrote:
> > > > > +
> > > > > +config TYPEC
> > > > > + tristate
> > > >
> > > > Hah, that says NOTHING about what this code is at all.
> > >
> > > Alone the class driver does nothing. Why would the user need to be
> > > aware of if it when selecting the Type-C drivers, and what can the
> > > user use that information for?
> >
> > If you see a blank Kconfig option, what are you supposed to do with it?
> > How do you know if you need to enable it or not? Are you just supposed
> > to guess?
>
> But you don't see anything when you are selecting the drivers and that
> is the point. You now can't select this separately. There is now no
> option for it.
>
> Why should we bother the user with this? The user is most likely only
> interested in the drivers and by selecting those the user will get the
> interface. The drivers will need to have the dependency to the class
> set correctly in any case.
So with this patch, no code gets built or asked about in Kconfig?
Odd, if so, sorry for the noise...
greg k-h
next prev parent reply other threads:[~2016-11-22 8:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 10:50 [PATCHv11 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-21 10:33 ` Greg KH
2016-11-21 13:27 ` Heikki Krogerus
2016-11-21 14:46 ` Greg KH
2016-11-22 7:58 ` Heikki Krogerus
2016-11-22 8:19 ` Greg KH [this message]
2016-11-21 10:35 ` Greg KH
2016-11-21 13:11 ` Heikki Krogerus
2016-11-21 14:23 ` Heikki Krogerus
2016-11-21 15:33 ` Guenter Roeck
2016-11-22 8:52 ` Heikki Krogerus
2016-11-21 14:45 ` Greg KH
2016-11-22 10:51 ` Heikki Krogerus
2016-11-22 13:37 ` Heikki Krogerus
2016-11-22 13:45 ` Heikki Krogerus
2016-11-17 10:50 ` [PATCHv11 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122081942.GA30186@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).