From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Binoy Jayan <binoy.jayan@linaro.org>,
linux-rdma@vger.kernel.org,
Mustafa Ismail <mustafa.ismail@intel.com>,
Lijun Ou <oulijun@huawei.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Leon Romanovsky <leonro@mellanox.com>,
target-devel@vger.kernel.org,
Tatyana E Nikolova <tatyana.e.nikolova@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jenny Derzhavetz <jennyf@mellanox.com>,
Sagi Grimberg <sagi@grimberg.me>,
Sean Hefty <sean.hefty@intel.com>,
Faisal Latif <faisal.latif@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-kernel@vger.kernel.org,
"Wei Hu(Xavier)" <xavier.huwei@huawei.com>,
Mark Brown <broonie@kernel.org>, Mark Bloch <markb@mellanox.com>,
Steve Wise <swise@opengridcomputing.com>,
Ira Weiny <ira.weiny@intel.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Matan Barak <matanb@mellanox.com>,
Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [PATCH v5 2/9] IB/core: Replace semaphore sm_sem with an atomic wait
Date: Mon, 21 Nov 2016 08:57:52 -0800 [thread overview]
Message-ID: <20161121165752.GA12866@infradead.org> (raw)
In-Reply-To: <4374986.OFD8bCgUa1@wuerfel>
On Mon, Nov 21, 2016 at 05:52:27PM +0100, Arnd Bergmann wrote:
> I think a mutex would't work here, since fops->open() and fops->close()
> are not called from the same context and lockdep will complain
> about that.
>
> Version of the series had replaced the semaphore with a completion
> here, which worked correctly, but one reviewer suggested using
> the wait_event() instead since it's confusing to have a completion
> starting out in 'completed' state.
On the other hand the existing semaphore works perfectly fine, and
is way easier to understand than any of the other models, which also
don't provide any benefit at all.
Please stop messing with perfectly fine semaphores now - there are
plenty that are much better replaced with mutexes or completions,
but this (and various others are not). Leave them alone and do
something useful instead.
next prev parent reply other threads:[~2016-11-21 16:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 6:08 [PATCH v5 0/9] infiniband: Remove semaphores Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 1/9] IB/core: iwpm_nlmsg_request: Replace semaphore with completion Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 2/9] IB/core: Replace semaphore sm_sem with an atomic wait Binoy Jayan
[not found] ` <CA+55aFxGjaqduhRCyk0mVxEA7aqQ-omdG8SBreZ=x5cW2ovngQ@mail.gmail.com>
2016-11-21 16:52 ` Arnd Bergmann
2016-11-21 16:57 ` Christoph Hellwig [this message]
2016-11-21 17:57 ` Linus Torvalds
2016-11-21 22:51 ` Arnd Bergmann
2016-11-21 6:08 ` [PATCH v5 3/9] IB/hns: Replace semaphore poll_sem with mutex Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 4/9] IB/mthca: " Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 5/9] IB/isert: Replace semaphore sem with completion Binoy Jayan
2016-11-21 7:36 ` Sagi Grimberg
2016-11-21 10:22 ` Arnd Bergmann
2016-11-21 12:33 ` Sagi Grimberg
2016-11-21 14:50 ` Arnd Bergmann
2016-11-21 6:08 ` [PATCH v5 6/9] IB/hns: Replace counting semaphore event_sem with wait_event Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 7/9] IB/mthca: " Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 8/9] IB/mlx5: Add helper mlx5_ib_post_send_wait Binoy Jayan
2016-11-21 6:08 ` [PATCH v5 9/9] IB/mlx5: Replace semaphore umr_common:sem with wait_event Binoy Jayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121165752.GA12866@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=bart.vanassche@sandisk.com \
--cc=binoy.jayan@linaro.org \
--cc=broonie@kernel.org \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jennyf@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=matanb@mellanox.com \
--cc=mustafa.ismail@intel.com \
--cc=nab@linux-iscsi.org \
--cc=oulijun@huawei.com \
--cc=sagi@grimberg.me \
--cc=sagig@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=swise@opengridcomputing.com \
--cc=target-devel@vger.kernel.org \
--cc=tatyana.e.nikolova@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).