* [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function
@ 2016-11-24 8:21 Viresh Kumar
2016-11-24 8:45 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2016-11-24 8:21 UTC (permalink / raw)
To: Rafael Wysocki, Ingo Molnar, Peter Zijlstra
Cc: linaro-kernel, linux-pm, linux-kernel, Vincent Guittot,
Viresh Kumar, Ingo Molnar
This patch rectifies a comment present in sugov_irq_work() function to
follow proper grammar.
Suggested-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
kernel/sched/cpufreq_schedutil.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 42a220e78f00..71e1a980d40a 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
/*
- * For Real Time and Deadline tasks, schedutil governor shoots the
- * frequency to maximum. And special care must be taken to ensure that
- * this kthread doesn't result in that.
+ * For Real Time and Deadline tasks, the schedutil governor shoots the
+ * frequency to maximum. Special care must be taken to ensure that this
+ * kthread doesn't result in the same behavior.
*
* This is (mostly) guaranteed by the work_in_progress flag. The flag is
- * updated only at the end of the sugov_work() and before that schedutil
- * rejects all other frequency scaling requests.
+ * updated only at the end of the sugov_work() function and before that
+ * the schedutil governor rejects all other frequency scaling requests.
*
- * Though there is a very rare case where the RT thread yields right
+ * There is a very rare case though, where the RT thread yields right
* after the work_in_progress flag is cleared. The effects of that are
* neglected for now.
*/
--
2.7.1.410.g6faf27b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function
2016-11-24 8:21 [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function Viresh Kumar
@ 2016-11-24 8:45 ` Ingo Molnar
2016-11-24 21:05 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2016-11-24 8:45 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Ingo Molnar, Peter Zijlstra, linaro-kernel,
linux-pm, linux-kernel, Vincent Guittot
* Viresh Kumar <viresh.kumar@linaro.org> wrote:
> This patch rectifies a comment present in sugov_irq_work() function to
> follow proper grammar.
>
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> kernel/sched/cpufreq_schedutil.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 42a220e78f00..71e1a980d40a 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
> sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
>
> /*
> + * For Real Time and Deadline tasks, the schedutil governor shoots the
> + * frequency to maximum. Special care must be taken to ensure that this
> + * kthread doesn't result in the same behavior.
> *
> * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> + * updated only at the end of the sugov_work() function and before that
> + * the schedutil governor rejects all other frequency scaling requests.
> *
> + * There is a very rare case though, where the RT thread yields right
> * after the work_in_progress flag is cleared. The effects of that are
> * neglected for now.
> */
Also:
s/Real Time task/RT task
s/Deadline task/deadline task
With those:
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function
2016-11-24 8:45 ` Ingo Molnar
@ 2016-11-24 21:05 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-11-24 21:05 UTC (permalink / raw)
To: Ingo Molnar
Cc: Viresh Kumar, Rafael Wysocki, Ingo Molnar, Peter Zijlstra,
Lists linaro-kernel, Linux PM, Linux Kernel Mailing List,
Vincent Guittot
On Thu, Nov 24, 2016 at 9:45 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
>> This patch rectifies a comment present in sugov_irq_work() function to
>> follow proper grammar.
>>
>> Suggested-by: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> kernel/sched/cpufreq_schedutil.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
>> index 42a220e78f00..71e1a980d40a 100644
>> --- a/kernel/sched/cpufreq_schedutil.c
>> +++ b/kernel/sched/cpufreq_schedutil.c
>> @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
>> sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
>>
>> /*
>> + * For Real Time and Deadline tasks, the schedutil governor shoots the
>> + * frequency to maximum. Special care must be taken to ensure that this
>> + * kthread doesn't result in the same behavior.
>> *
>> * This is (mostly) guaranteed by the work_in_progress flag. The flag is
>> + * updated only at the end of the sugov_work() function and before that
>> + * the schedutil governor rejects all other frequency scaling requests.
>> *
>> + * There is a very rare case though, where the RT thread yields right
>> * after the work_in_progress flag is cleared. The effects of that are
>> * neglected for now.
>> */
>
> Also:
>
> s/Real Time task/RT task
> s/Deadline task/deadline task
>
> With those:
>
> Acked-by: Ingo Molnar <mingo@kernel.org>
>
Fixed up and applied.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-24 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-24 8:21 [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work() function Viresh Kumar
2016-11-24 8:45 ` Ingo Molnar
2016-11-24 21:05 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).