linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V1] leds: pca963x: Add ACPI support
@ 2016-11-29  4:18 Tin Huynh
  2016-11-29  9:15 ` Mika Westerberg
  0 siblings, 1 reply; 5+ messages in thread
From: Tin Huynh @ 2016-11-29  4:18 UTC (permalink / raw)
  To: Mika Westerberg, Rafael J. Wysocki, Richard Purdie, Jacek Anaszewski
  Cc: linux-leds, linux-kernel, linux-acpi, Loc Ho, Thang Nguyen,
	Phong Vo, patches, Tin Huynh

This patch enables ACPI support for leds-pca963x driver.

Signed-off-by: Tin Huynh <tnhuynh@apm.com>
---
 drivers/leds/leds-pca963x.c |   22 +++++++++++++++++++++-
 1 files changed, 21 insertions(+), 1 deletions(-)

diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
index 407eba1..be51a12 100644
--- a/drivers/leds/leds-pca963x.c
+++ b/drivers/leds/leds-pca963x.c
@@ -25,6 +25,7 @@
  * or by adding the 'nxp,hw-blink' property to the DTS.
  */
 
+#include <linux/acpi.h>
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/string.h>
@@ -95,6 +96,15 @@ struct pca963x_chipdef {
 };
 MODULE_DEVICE_TABLE(i2c, pca963x_id);
 
+static const struct acpi_device_id pca963x_acpi_ids[] = {
+	{ "PCA9632", pca9633 },
+	{ "PCA9633", pca9633 },
+	{ "PCA9634", pca9634 },
+	{ "PCA9635", pca9635 },
+	{ }
+};
+MODULE_DEVICE_TABLE(acpi, pca963x_acpi_ids);
+
 struct pca963x_led;
 
 struct pca963x {
@@ -322,7 +332,16 @@ static int pca963x_probe(struct i2c_client *client,
 	struct pca963x_chipdef *chip;
 	int i, err;
 
-	chip = &pca963x_chipdefs[id->driver_data];
+	if (id) {
+		chip = &pca963x_chipdefs[id->driver_data];
+	} else {
+		const struct acpi_device_id *acpi_id;
+
+		acpi_id = acpi_match_device(pca963x_acpi_ids, &client->dev);
+		if (!acpi_id)
+			return -ENODEV;
+		chip = &pca963x_chipdefs[acpi_id->driver_data];
+	}
 	pdata = dev_get_platdata(&client->dev);
 
 	if (!pdata) {
@@ -426,6 +445,7 @@ static int pca963x_remove(struct i2c_client *client)
 	.driver = {
 		.name	= "leds-pca963x",
 		.of_match_table = of_match_ptr(of_pca963x_match),
+		.acpi_match_table = ACPI_PTR(pca963x_acpi_ids),
 	},
 	.probe	= pca963x_probe,
 	.remove	= pca963x_remove,
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] leds: pca963x: Add ACPI support
  2016-11-29  4:18 [PATCH V1] leds: pca963x: Add ACPI support Tin Huynh
@ 2016-11-29  9:15 ` Mika Westerberg
  2016-11-29 10:04   ` Jacek Anaszewski
  0 siblings, 1 reply; 5+ messages in thread
From: Mika Westerberg @ 2016-11-29  9:15 UTC (permalink / raw)
  To: Tin Huynh
  Cc: Rafael J. Wysocki, Richard Purdie, Jacek Anaszewski, linux-leds,
	linux-kernel, linux-acpi, Loc Ho, Thang Nguyen, Phong Vo,
	patches

On Tue, Nov 29, 2016 at 11:18:20AM +0700, Tin Huynh wrote:
> This patch enables ACPI support for leds-pca963x driver.
> 
> Signed-off-by: Tin Huynh <tnhuynh@apm.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] leds: pca963x: Add ACPI support
  2016-11-29  9:15 ` Mika Westerberg
@ 2016-11-29 10:04   ` Jacek Anaszewski
  2016-11-29 10:09     ` Tin Huynh
  0 siblings, 1 reply; 5+ messages in thread
From: Jacek Anaszewski @ 2016-11-29 10:04 UTC (permalink / raw)
  To: Mika Westerberg, Tin Huynh
  Cc: Rafael J. Wysocki, Richard Purdie, linux-leds, linux-kernel,
	linux-acpi, Loc Ho, Thang Nguyen, Phong Vo, patches

Hi Tin,

Thanks for the update.

On 11/29/2016 10:15 AM, Mika Westerberg wrote:
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Mika, thanks for the review.

Patch applied to the for-next branch of linux-leds.git.

-- 
Best regards,
Jacek Anaszewski

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] leds: pca963x: Add ACPI support
  2016-11-29 10:04   ` Jacek Anaszewski
@ 2016-11-29 10:09     ` Tin Huynh
  2016-11-29 10:24       ` Jacek Anaszewski
  0 siblings, 1 reply; 5+ messages in thread
From: Tin Huynh @ 2016-11-29 10:09 UTC (permalink / raw)
  To: Jacek Anaszewski
  Cc: Mika Westerberg, Rafael J. Wysocki, Richard Purdie, linux-leds,
	linux-kernel, linux-acpi, Loc Ho, Thang Nguyen, Phong Vo,
	patches

Hi
I got a small bug when compiling without CONFIG_ACPI
I will send out the patch to fix the problem later.

On Tue, Nov 29, 2016 at 5:04 PM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Hi Tin,
>
> Thanks for the update.
>
> On 11/29/2016 10:15 AM, Mika Westerberg wrote:
>>
>> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
>
> Mika, thanks for the review.
>
> Patch applied to the for-next branch of linux-leds.git.
>
> --
> Best regards,
> Jacek Anaszewski



-- 
Sr SW Eng

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] leds: pca963x: Add ACPI support
  2016-11-29 10:09     ` Tin Huynh
@ 2016-11-29 10:24       ` Jacek Anaszewski
  0 siblings, 0 replies; 5+ messages in thread
From: Jacek Anaszewski @ 2016-11-29 10:24 UTC (permalink / raw)
  To: Tin Huynh
  Cc: Mika Westerberg, Rafael J. Wysocki, Richard Purdie, linux-leds,
	linux-kernel, linux-acpi, Loc Ho, Thang Nguyen, Phong Vo,
	patches

On 11/29/2016 11:09 AM, Tin Huynh wrote:
> Hi
> I got a small bug when compiling without CONFIG_ACPI
> I will send out the patch to fix the problem later.

Dropping the patch then.
Could you share the details?

Thanks,
Jacek Anaszewski

> On Tue, Nov 29, 2016 at 5:04 PM, Jacek Anaszewski
> <j.anaszewski@samsung.com> wrote:
>> Hi Tin,
>>
>> Thanks for the update.
>>
>> On 11/29/2016 10:15 AM, Mika Westerberg wrote:
>>>
>>> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>>
>> Mika, thanks for the review.
>>
>> Patch applied to the for-next branch of linux-leds.git.
>>
>> --
>> Best regards,
>> Jacek Anaszewski
>
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-11-29 10:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-29  4:18 [PATCH V1] leds: pca963x: Add ACPI support Tin Huynh
2016-11-29  9:15 ` Mika Westerberg
2016-11-29 10:04   ` Jacek Anaszewski
2016-11-29 10:09     ` Tin Huynh
2016-11-29 10:24       ` Jacek Anaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).