* Re: [PATCH] staging: octeon-usb: Resolve some checkpatch.pl warnings
@ 2016-12-01 15:16 Geert Custers
2016-12-01 15:22 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Geert Custers @ 2016-12-01 15:16 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, aaro.koskinen
I am, you and Aaro are listed.
Regards,
Geert Custers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: octeon-usb: Resolve some checkpatch.pl warnings
2016-12-01 15:16 [PATCH] staging: octeon-usb: Resolve some checkpatch.pl warnings Geert Custers
@ 2016-12-01 15:22 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-12-01 15:22 UTC (permalink / raw)
To: Geert Custers; +Cc: linux-kernel, aaro.koskinen
On Thu, Dec 01, 2016 at 04:16:38PM +0100, Geert Custers wrote:
> I am, you and Aaro are listed.
What in the world are you responding to here?
totally lost,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: octeon-usb: Resolve some checkpatch.pl warnings
2016-12-01 14:58 Geert Custers
@ 2016-12-01 15:11 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-12-01 15:11 UTC (permalink / raw)
To: Geert Custers; +Cc: aaro.koskinen, linux-kernel
On Thu, Dec 01, 2016 at 03:58:12PM +0100, Geert Custers wrote:
> This patch removes some of the warnings that are present when running
> the checkpatch.pl script. It corrects the warnings related to macro
> precedents.
>
> Signed-off-by: Geert Custers <geert.aj.custers@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> drivers/staging/octeon-usb/octeon-hcd.h | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
Why are you not using scripts/get_maintainer.pl to determine what
mailing list you should be sending patches like this to?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: octeon-usb: Resolve some checkpatch.pl warnings
@ 2016-12-01 14:58 Geert Custers
2016-12-01 15:11 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Geert Custers @ 2016-12-01 14:58 UTC (permalink / raw)
To: aaro.koskinen; +Cc: linux-kernel, gregkh
This patch removes some of the warnings that are present when running
the checkpatch.pl script. It corrects the warnings related to macro
precedents.
Signed-off-by: Geert Custers <geert.aj.custers@gmail.com>
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
drivers/staging/octeon-usb/octeon-hcd.h | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index 9a7858a..9e6974e 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -380,7 +380,7 @@ struct octeon_hcd {
#define CVMX_WAIT_FOR_FIELD32(address, _union, cond, timeout_usec) \
({int result; \
do { \
- u64 done = cvmx_get_cycle() + (u64)timeout_usec * \
+ u64 done = cvmx_get_cycle() + (u64)(timeout_usec) * \
octeon_get_clock_rate() / 1000000; \
union _union c; \
\
diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
index 3353aefe..dc702fc 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.h
+++ b/drivers/staging/octeon-usb/octeon-hcd.h
@@ -51,10 +51,10 @@
#define CVMX_USBCXBASE 0x00016F0010000000ull
#define CVMX_USBCXREG1(reg, bid) \
- (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | reg) + \
+ (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | (reg)) + \
((bid) & 1) * 0x100000000000ull)
#define CVMX_USBCXREG2(reg, bid, off) \
- (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | reg) + \
+ (CVMX_ADD_IO_SEG(CVMX_USBCXBASE | (reg)) + \
(((off) & 7) + ((bid) & 1) * 0x8000000000ull) * 32)
#define CVMX_USBCX_GAHBCFG(bid) CVMX_USBCXREG1(0x008, bid)
@@ -86,9 +86,9 @@
#define CVMX_USBNXBID2(bid) (((bid) & 1) * 0x100000000000ull)
#define CVMX_USBNXREG1(reg, bid) \
- (CVMX_ADD_IO_SEG(0x0001180068000000ull | reg) + CVMX_USBNXBID1(bid))
+ (CVMX_ADD_IO_SEG(0x0001180068000000ull | (reg)) + CVMX_USBNXBID1(bid))
#define CVMX_USBNXREG2(reg, bid) \
- (CVMX_ADD_IO_SEG(0x00016F0000000000ull | reg) + CVMX_USBNXBID2(bid))
+ (CVMX_ADD_IO_SEG(0x00016F0000000000ull | (reg)) + CVMX_USBNXBID2(bid))
#define CVMX_USBNX_CLK_CTL(bid) CVMX_USBNXREG1(0x10, bid)
#define CVMX_USBNX_DMA0_INB_CHN0(bid) CVMX_USBNXREG2(0x818, bid)
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-01 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-01 15:16 [PATCH] staging: octeon-usb: Resolve some checkpatch.pl warnings Geert Custers
2016-12-01 15:22 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-12-01 14:58 Geert Custers
2016-12-01 15:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).