linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: Sebastian Duda <sebastian.duda@fau.de>,
	linux-kernel@i4.cs.fau.de,
	Tobias Baumeister <tobias.baumeister@fau.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Borislav Petkov <bp@suse.de>, Tejun Heo <tj@kernel.org>,
	Thierry Reding <treding@nvidia.com>,
	open list <linux-kernel@vger.kernel.org>,
	lkp@01.org
Subject: Re: [lkp] [printk.c]  ea0639c4d5: BUG:recent_printk_recursion
Date: Fri, 2 Dec 2016 11:05:58 +0100	[thread overview]
Message-ID: <20161202100558.GR21230@pathway.suse.cz> (raw)
In-Reply-To: <20161201171232.GD31607@yexl-desktop>

On Fri 2016-12-02 01:12:32, kernel test robot wrote:
> 
> FYI, we noticed the following commit:
> 
> commit: ea0639c4d5c700ad63c0ace6a7a17877aac5b4c2 ("printk.c: removed unnecessary code")
> url: https://github.com/0day-ci/linux/commits/Sebastian-Duda/printk-c-removed-unnecessary-code/20161130-225006
> 
> 
> in testcase: trinity
> with following parameters:
> 
> 	runtime: 300s
> 
> test-description: Trinity is a linux system call fuzz tester.
> test-url: http://codemonkey.org.uk/projects/trinity/
> 
> 
> on test machine: qemu-system-i386 -enable-kvm -m 256M
> 
> caused below changes:
> 
> 
> +-------------------------------------------------------+------------+------------+
> |                                                       | ded6e842cf | ea0639c4d5 |
> +-------------------------------------------------------+------------+------------+
> | boot_successes                                        | 19         | 8          |
> | boot_failures                                         | 3          | 49         |

I am not surprised. The patch breaks counting of the space
needed to print the message. It is likely to cause buffer
overflows. I have already nacked it, see
https://lkml.kernel.org/r/20161130102231.GE24060@pathway.suse.cz

Anyway, thanks for testing.

Best Regards,
Petr

      reply	other threads:[~2016-12-02 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 15:19 [PATCH] printk.c: removed unnecessary code Sebastian Duda
2016-11-30  9:14 ` Michal Hocko
2016-11-30 10:22   ` Petr Mladek
2016-12-01 17:12 ` [lkp] [printk.c] ea0639c4d5: BUG:recent_printk_recursion kernel test robot
2016-12-02 10:05   ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161202100558.GR21230@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=sebastian.duda@fau.de \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tj@kernel.org \
    --cc=tobias.baumeister@fau.de \
    --cc=treding@nvidia.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).