Re: [PATCH 1/3] USB: OHCI: at91: remove useless extern declaration

Re: [PATCH 1/3] USB: OHCI: at91: remove useless extern declaration

[Greg Kroah-Hartman]

On Sat, Dec 03, 2016 at 03:25:21AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration in drivers/usb/core/usb.c

The EXPORT_SYMBOL_GPL() has nothing to do with this, it's the fact that
it is exported in include/linux/usb.h that matters.

Please fix the text up and resend.

thanks,

greg k-h

Re: [PATCH 2/3] USB: OHCI: omap: remove useless extern declaration

[Greg Kroah-Hartman]

On Sat, Dec 03, 2016 at 03:25:22AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() and ocpi_enable() extern declaration
> as it is already declared as EXPORT_SYMBOL_GPL declaration.

Same here, EXPORT_SYMBOL* doesn't matter for stuff like this.

thanks,

greg k-h

Re: [PATCH 3/3] USB: OHCI: nxp: remove useless extern declaration

[Greg Kroah-Hartman]

On Sat, Dec 03, 2016 at 03:25:23AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration.

And same thing again...

Re: [PATCH 3/3] USB: OHCI: nxp: remove useless extern declaration

[Greg Kroah-Hartman]

On Sat, Dec 03, 2016 at 03:25:23AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration.

merge this with your first patch please, it belongs with it.

Re: [PATCH v2 3/3] USB: OHCI: nxp: remove useless extern declaration

[Vladimir Zapolskiy]

On 12/08/2016 12:34 AM, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as extern in include/linux/usb.h.
> 
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Sylvain Lemieux <slemieux.tyco@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> changelog V1->V2:
> patch discrition is update with proper message.
> 

I'm fine with the change, thank you for the clean-up.

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
With best wishes,
Vladimir