* Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust
[not found] <CAEX1niU24TLaRff+TMPu4ek4vT=R2mv9yaE6j1W1ZsFYh99QGg@mail.gmail.com>
@ 2016-12-06 12:32 ` Jiri Pirko
2016-12-06 14:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2016-12-06 12:32 UTC (permalink / raw)
To: Feng Deng; +Cc: David S. Miller, netdev, linux-kernel, feng.deng
Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2006@gmail.com wrote:
>From: Feng Deng<cxdx2006@gmail.com>
>
>1.add judgement to make sure switchdev_port_vlan_fill() could
> return right, even when switchdev_port_vlan_dump_put() failed ,
> which will make switchdev_port_vlan_fill() more robust
>2.add proper return vlaue at the end of the switchdev_port_vlan_fill()
>
>Signed-off-by: Feng Deng <feng.deng@cortina-access.com>
Please don't send patches like this. You are wasting everyone's time.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust
2016-12-06 12:32 ` [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust Jiri Pirko
@ 2016-12-06 14:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-12-06 14:32 UTC (permalink / raw)
To: jiri; +Cc: cxdx2006, netdev, linux-kernel, feng.deng
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 6 Dec 2016 13:32:25 +0100
> Tue, Dec 06, 2016 at 05:46:36AM CET, cxdx2006@gmail.com wrote:
>>From: Feng Deng<cxdx2006@gmail.com>
>>
>>1.add judgement to make sure switchdev_port_vlan_fill() could
>> return right, even when switchdev_port_vlan_dump_put() failed ,
>> which will make switchdev_port_vlan_fill() more robust
>>2.add proper return vlaue at the end of the switchdev_port_vlan_fill()
>>
>>Signed-off-by: Feng Deng <feng.deng@cortina-access.com>
>
> Please don't send patches like this. You are wasting everyone's time.
+1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-06 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAEX1niU24TLaRff+TMPu4ek4vT=R2mv9yaE6j1W1ZsFYh99QGg@mail.gmail.com>
2016-12-06 12:32 ` [PATCH]net:switchdev:add judgement and proper return vlaue to make switchdev_port_vlan_fill() more robust Jiri Pirko
2016-12-06 14:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).