From: Greg KH <gregkh@linuxfoundation.org>
To: Shiva Kerdel <shiva@exdev.nl>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
Date: Tue, 6 Dec 2016 10:12:22 +0100 [thread overview]
Message-ID: <20161206091222.GA12130@kroah.com> (raw)
In-Reply-To: <20161206085958.5286-1-shiva@exdev.nl>
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote:
> In most cases, usleep_range is better than udelay, as the precise wakeup
> from udelay is unnecessary.
But, udelay does something different than usleep, are you sure you
should be giving up the cpu at this point in time?
Are you sure you are even in a function that is allowed to sleep? I
don't think that is the case for all of these at all, sorry, unless you
have the hardware to test this change, I can't take it.
greg k-h
next prev parent reply other threads:[~2016-12-06 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 8:59 [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups Shiva Kerdel
2016-12-06 9:12 ` Greg KH [this message]
2016-12-06 10:01 ` Shiva Kerdel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206091222.GA12130@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=shiva@exdev.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).