From: Shiva Kerdel <shiva@exdev.nl>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
Date: Tue, 6 Dec 2016 11:01:48 +0100 [thread overview]
Message-ID: <269ff7f4-c8f2-347e-835a-a5509bbb739a@exdev.nl> (raw)
In-Reply-To: <20161206091222.GA12130@kroah.com>
> On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote:
>> In most cases, usleep_range is better than udelay, as the precise wakeup
>> from udelay is unnecessary.
> But, udelay does something different than usleep, are you sure you
> should be giving up the cpu at this point in time?
>
> Are you sure you are even in a function that is allowed to sleep? I
> don't think that is the case for all of these at all, sorry, unless you
> have the hardware to test this change, I can't take it.
>
> greg k-h
I wasn't aware of this, thank you for pointing out.
Since I don't have this hardware, I'm unable to test the changes.
Shiva Kerdel
prev parent reply other threads:[~2016-12-06 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 8:59 [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups Shiva Kerdel
2016-12-06 9:12 ` Greg KH
2016-12-06 10:01 ` Shiva Kerdel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=269ff7f4-c8f2-347e-835a-a5509bbb739a@exdev.nl \
--to=shiva@exdev.nl \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).