From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Thomas Casey <tqcasey@gmail.com>
Cc: tglx@linutronix.de, anna-maria@linutronix.de,
peterz@infradead.org, linux@rasmusvillemoes.dk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix style issues in kernel/cpu.c
Date: Tue, 6 Dec 2016 12:13:19 +0100 [thread overview]
Message-ID: <20161206111319.bdzj3lawxyeyg34l@linutronix.de> (raw)
In-Reply-To: <20161203010958.GA910@loonix.localdomain>
On 2016-12-03 01:09:58 [+0000], Thomas Casey wrote:
> This patch fixes style issues in kernel/cpu.c such as wrapping an 80
> character line, calling EXPORT_SYMBOL() immediately after a function is
> defined, and whitespace and spacing issues.
>
> Signed-off-by: Thomas Casey <tqcasey@gmail.com>
This is okay for most of it.
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -353,6 +354,7 @@ EXPORT_SYMBOL_GPL(cpu_hotplug_enable);
> int register_cpu_notifier(struct notifier_block *nb)
> {
> int ret;
> +
> cpu_maps_update_begin();
> ret = raw_notifier_chain_register(&cpu_chain, nb);
> cpu_maps_update_done();
> @@ -363,6 +365,7 @@ int __register_cpu_notifier(struct notifier_block *nb)
> {
> return raw_notifier_chain_register(&cpu_chain, nb);
> }
> +EXPORT_SYMBOL(__register_cpu_notifier);
>
> static int __cpu_notify(unsigned long val, unsigned int cpu, int nr_to_call,
> int *nr_calls)
> @@ -661,7 +664,6 @@ void __init cpuhp_threads_init(void)
>
> #ifdef CONFIG_HOTPLUG_CPU
> EXPORT_SYMBOL(register_cpu_notifier);
> -EXPORT_SYMBOL(__register_cpu_notifier);
> void unregister_cpu_notifier(struct notifier_block *nb)
> {
> cpu_maps_update_begin();
I have a patch posted which gets rid of register_cpu_notifier() and
__register_cpu_notifier() so there is probably no point in fixing /
changing those.
Sebastian
prev parent reply other threads:[~2016-12-06 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 1:09 [PATCH] Fix style issues in kernel/cpu.c Thomas Casey
2016-12-06 11:13 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206111319.bdzj3lawxyeyg34l@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tqcasey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).