From: Andrew Morton <akpm@linux-foundation.org>
To: Jungseung Lee <js07.lee@samsung.com>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
Adrian Bunk <bunk@stusta.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init : Reduce rootwait polling interval time to 5ms
Date: Wed, 7 Dec 2016 12:47:47 -0800 [thread overview]
Message-ID: <20161207124747.62043547ff990002b8e9b4ee@linux-foundation.org> (raw)
In-Reply-To: <20161207060743.1728-1-js07.lee@samsung.com>
On Wed, 07 Dec 2016 15:07:43 +0900 Jungseung Lee <js07.lee@samsung.com> wrote:
> For several devices, the rootwait time is sensitive because it directly
> affects booting time.
> The polling interval of rootwait is currently 100ms.
> To save unnessesary waiting time, reduce the polling interval to 5 ms.
>
> ...
>
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -543,6 +543,8 @@ void __init mount_root(void)
> #endif
> }
>
> +#define ROOTWAIT_MSEC 5
> +
> /*
> * Prepare the namespace - decide what/where to mount, load ramdisks, etc.
> */
> @@ -588,7 +590,7 @@ void __init prepare_namespace(void)
> saved_root_name);
> while (driver_probe_done() != 0 ||
> (ROOT_DEV = name_to_dev_t(saved_root_name)) == 0)
> - msleep(100);
> + msleep(ROOTWAIT_MSEC);
> async_synchronize_full();
> }
Fair enough. But I don't think the used-once #define adds any value,
so let's go with the simple version?
--- a/init/do_mounts.c~init-reduce-rootwait-polling-interval-time-to-5ms-fix
+++ a/init/do_mounts.c
@@ -543,8 +543,6 @@ void __init mount_root(void)
#endif
}
-#define ROOTWAIT_MSEC 5
-
/*
* Prepare the namespace - decide what/where to mount, load ramdisks, etc.
*/
@@ -590,7 +588,7 @@ void __init prepare_namespace(void)
saved_root_name);
while (driver_probe_done() != 0 ||
(ROOT_DEV = name_to_dev_t(saved_root_name)) == 0)
- msleep(ROOTWAIT_MSEC);
+ msleep(5);
async_synchronize_full();
}
_
prev parent reply other threads:[~2016-12-07 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161207060804eucas1p11b55de7e87a1dbc684c274b31fc4536c@eucas1p1.samsung.com>
2016-12-07 6:07 ` [PATCH] init : Reduce rootwait polling interval time to 5ms Jungseung Lee
2016-12-07 20:47 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207124747.62043547ff990002b8e9b4ee@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=drzeus-list@drzeus.cx \
--cc=hch@lst.de \
--cc=js07.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).