* [PATCH] init : Reduce rootwait polling interval time to 5ms
[not found] <CGME20161207060804eucas1p11b55de7e87a1dbc684c274b31fc4536c@eucas1p1.samsung.com>
@ 2016-12-07 6:07 ` Jungseung Lee
2016-12-07 20:47 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Jungseung Lee @ 2016-12-07 6:07 UTC (permalink / raw)
To: Pierre Ossman, Al Viro, Christoph Hellwig, Adrian Bunk,
Andrew Morton, linux-kernel
Cc: Jungseung Lee
For several devices, the rootwait time is sensitive because it directly
affects booting time.
The polling interval of rootwait is currently 100ms.
To save unnessesary waiting time, reduce the polling interval to 5 ms.
Signed-off-by: Jungseung Lee <js07.lee@samsung.com>
---
init/do_mounts.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/init/do_mounts.c b/init/do_mounts.c
index dea5de9..b523820 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -543,6 +543,8 @@ void __init mount_root(void)
#endif
}
+#define ROOTWAIT_MSEC 5
+
/*
* Prepare the namespace - decide what/where to mount, load ramdisks, etc.
*/
@@ -588,7 +590,7 @@ void __init prepare_namespace(void)
saved_root_name);
while (driver_probe_done() != 0 ||
(ROOT_DEV = name_to_dev_t(saved_root_name)) == 0)
- msleep(100);
+ msleep(ROOTWAIT_MSEC);
async_synchronize_full();
}
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] init : Reduce rootwait polling interval time to 5ms
2016-12-07 6:07 ` [PATCH] init : Reduce rootwait polling interval time to 5ms Jungseung Lee
@ 2016-12-07 20:47 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2016-12-07 20:47 UTC (permalink / raw)
To: Jungseung Lee
Cc: Pierre Ossman, Al Viro, Christoph Hellwig, Adrian Bunk, linux-kernel
On Wed, 07 Dec 2016 15:07:43 +0900 Jungseung Lee <js07.lee@samsung.com> wrote:
> For several devices, the rootwait time is sensitive because it directly
> affects booting time.
> The polling interval of rootwait is currently 100ms.
> To save unnessesary waiting time, reduce the polling interval to 5 ms.
>
> ...
>
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -543,6 +543,8 @@ void __init mount_root(void)
> #endif
> }
>
> +#define ROOTWAIT_MSEC 5
> +
> /*
> * Prepare the namespace - decide what/where to mount, load ramdisks, etc.
> */
> @@ -588,7 +590,7 @@ void __init prepare_namespace(void)
> saved_root_name);
> while (driver_probe_done() != 0 ||
> (ROOT_DEV = name_to_dev_t(saved_root_name)) == 0)
> - msleep(100);
> + msleep(ROOTWAIT_MSEC);
> async_synchronize_full();
> }
Fair enough. But I don't think the used-once #define adds any value,
so let's go with the simple version?
--- a/init/do_mounts.c~init-reduce-rootwait-polling-interval-time-to-5ms-fix
+++ a/init/do_mounts.c
@@ -543,8 +543,6 @@ void __init mount_root(void)
#endif
}
-#define ROOTWAIT_MSEC 5
-
/*
* Prepare the namespace - decide what/where to mount, load ramdisks, etc.
*/
@@ -590,7 +588,7 @@ void __init prepare_namespace(void)
saved_root_name);
while (driver_probe_done() != 0 ||
(ROOT_DEV = name_to_dev_t(saved_root_name)) == 0)
- msleep(ROOTWAIT_MSEC);
+ msleep(5);
async_synchronize_full();
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-07 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20161207060804eucas1p11b55de7e87a1dbc684c274b31fc4536c@eucas1p1.samsung.com>
2016-12-07 6:07 ` [PATCH] init : Reduce rootwait polling interval time to 5ms Jungseung Lee
2016-12-07 20:47 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).